Conversation
- Introduced `taskfile.yaml` to streamline common tasks such as formatting, restoring, building, and packing. - Updated `.gitignore` to exclude generated `nupkg` directory. - Included `taskfile.yaml` in the solution directory for better visibility.
- Added `clean` task to remove NuGet packages and clean Release folder. - Introduced `publish` task for publishing packages to NuGet, with dependency on `pack`. - Updated `.gitignore` to correctly ignore `.env` file instead of all `*.env` files. - Linked `clean` task as a dependency for `restore` to ensure a fresh workspace.
- Removed `dotenv` configuration as it was unused. - Deleted `publish` task to simplify the taskfile and remove NuGet publish workflow.
- Suppressed dependency/content warnings during source generator packaging. - Updated analyzer packaging to use `@(IntermediateAssembly)` for better reliability. - Added a target to include analyzer dependencies, e.g., `PolySharp`, in the package if required.
- Removed redundant `<ItemGroup>` entries from project files for `icon.png` and `README.md`. - Centralized `icon` and `README` inclusion in `Directory.Build.props` for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the build and packaging infrastructure for the source generator project by:
Changes
Taskfile Workflow
Added
taskfile.yamlwith the following tasks:format: Reformat code using CSharpierclean: Clean build artifacts and NuGet packagesrestore: Restore NuGet dependenciesbuild: Build solution in Release configurationpack: Create NuGet packagesSource Generator Packaging
Enhanced
LayeredCraft.SourceGeneratorTools.Generator.csproj:SuppressDependenciesWhenPacking@(IntermediateAssembly)for more reliable packagingBuild Configuration
./nupkgdirectoryChecklist
Related Issues/PRs
N/A
Reviewer Notes
The key improvements are:
IncludeAnalyzerDependenciesensures PolySharp is included with the generatorPlease verify that the generated NuGet package structure is correct and that the source generator works when referenced from another project.