Skip to content

ci(github): align NuGet publish workflows#377

Merged
j-d-ha merged 2 commits into
mainfrom
ci/github-align-publish-workflows
Jul 20, 2026
Merged

ci(github): align NuGet publish workflows#377
j-d-ha merged 2 commits into
mainfrom
ci/github-align-publish-workflows

Conversation

@j-d-ha

@j-d-ha j-d-ha commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Align NuGet publish workflows with working LayeredCraft repositories such as dynamodb-efcore-provider. This keeps trusted publishing wired through the org-level NUGET_USER secret and caller-owned OIDC push job.

Changes

  • Set top-level publish workflow permissions to contents: read.
  • Move elevated contents: write / pull-requests: write permissions onto the build jobs.
  • Remove explicit artifact-name overrides and rely on shared workflow/action defaults.
  • Keep push jobs using id-token: write and ${{ secrets.NUGET_USER }}.

Validation

  • YAML parsed locally with Ruby YAML.load_file.
  • Compared against existing LayeredCraft publish workflows.

Notes for Reviewers

Publishing still depends on the org-level NUGET_USER secret being available to this repo and NuGet trusted publisher policies matching the workflow paths.

@github-actions github-actions Bot added the type: ci CI/CD changes label Jul 20, 2026
ncipollina
ncipollina previously approved these changes Jul 20, 2026

@ncipollina ncipollina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread .github/workflows/publish-preview.yaml
@j-d-ha
j-d-ha enabled auto-merge (squash) July 20, 2026 19:43
@j-d-ha
j-d-ha disabled auto-merge July 20, 2026 19:58
@j-d-ha
j-d-ha merged commit 678895a into main Jul 20, 2026
7 checks passed
@j-d-ha
j-d-ha deleted the ci/github-align-publish-workflows branch July 20, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: ci CI/CD changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants