ci(github): update devops template workflows#24
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbb731f7e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| jobs: | ||
| build: | ||
| uses: LayeredCraft/devops-templates/.github/workflows/pr-build.yaml@v6.2 | ||
| uses: LayeredCraft/devops-templates/.github/workflows/pr-build.yaml@v10.2 |
There was a problem hiding this comment.
Add MTP runner selection before switching PR template
With this upgrade, the v10.2 reusable PR workflow takes the existing useMtpRunner: true/enableCodeCoverage: true inputs and runs its MTP coverage path (dotnet test --solution ... --report-xunit-trx --coverage). The dotnet test CLI docs say MTP mode must be selected in global.json, while VSTest remains the default; I checked the repo with rg --files and there is no global.json, so PR builds will run the default VSTest parser and fail on the MTP-only options. Add the global.json test runner selection, or avoid the v10.2 MTP path until the repo opts into it.
Useful? React with 👍 / 👎.
Summary
Updates the remaining Lambda hosting workflows from the old
devops-templates@v6.2references tov10.2. This also removes inputs that are not valid for the reusable workflows and keeps the package build docs path filters aligned with the uv-based docs dependency files.Changes
.github/workflows/pr-build.yamlto useLayeredCraft/devops-templates/.github/workflows/pr-build.yaml@v10.2.testDirectoryinput from the PR build reusable workflow call..github/workflows/build.yamlto useLayeredCraft/devops-templates/.github/workflows/package-build.yaml@v10.2.useMtpRunnerandtestDirectory.requirements.txtpath ignore withpyproject.tomlanduv.lock.Validation
devops-templatesworkflow definitions.