ci(github): use app token for dependabot merges#285
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fb35d9781
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| app-id: ${{ secrets.DEPENDABOT_AUTOMERGE_APP_ID }} | ||
| private-key: ${{ secrets.DEPENDABOT_AUTOMERGE_PRIVATE_KEY }} |
There was a problem hiding this comment.
Avoid secrets in Dependabot pull_request_target runs
Because this job is restricted to dependabot[bot] pull_request_target events, these newly referenced app credentials are not available in the run; GitHub's secret-type docs state that Dependabot-initiated pull_request_target workflows receive a read-only GITHUB_TOKEN and no secrets (https://docs.github.com/en/code-security/reference/secret-security/secret-types#dependabot-secrets). As a result, actions/create-github-app-token will receive empty app credentials and fail before the approval/auto-merge steps for every eligible Dependabot patch/minor PR. Use a hand-off workflow under a non-Dependabot actor or another supported credential path.
Useful? React with 👍 / 👎.
Summary
Updates the Dependabot auto-merge workflow to use the LayeredCraft GitHub App token for approving and enabling auto-merge. This avoids using
GITHUB_TOKENfor the merge operation so downstream workflows can run after Dependabot auto-merged changes land onmain.Changes
actions/create-github-app-tokenstep for semver patch/minor Dependabot PRs.GH_TOKENforgh pr review --approveandgh pr merge --auto --squash.dependabot/fetch-metadataon the defaultGITHUB_TOKEN.Validation
Notes for Reviewers
Requires the Actions secrets
DEPENDABOT_AUTOMERGE_APP_IDandDEPENDABOT_AUTOMERGE_PRIVATE_KEYto be available to this repository.