Skip to content

Mkdocs#17

Merged
ncipollina merged 20 commits into
LayeredCraft:mainfrom
taylorbobaylor:mkdocs
Jul 10, 2025
Merged

Mkdocs#17
ncipollina merged 20 commits into
LayeredCraft:mainfrom
taylorbobaylor:mkdocs

Conversation

@taylorbobaylor

Copy link
Copy Markdown
Contributor

Pull Request

Summary

This pull request revamps the project's documentation by migrating to the Material for MkDocs theme, providing a modern, responsive, and more user-friendly documentation site.

Key improvements include:

  • A complete visual and functional overhaul of the documentation site.
  • Streamlined mkdocs.yml configuration by removing broken links and unused plugins.
  • Fixed the site logo path to ensure it renders correctly.
  • Updated the documentation deployment workflow (docs.yml) to resolve build failures caused by deprecated actions and to allow for manual workflow execution.

✅ Checklist

  • My changes build cleanly
  • I’ve added/updated relevant tests
  • I’ve added/updated documentation or README
  • I’ve followed the coding style for this project
  • I’ve tested the changes locally (if applicable)

Related Issues or PRs

Closes #...


Notes for Reviewers

  • Please review the rendered documentation site to ensure all content is displayed correctly with the new theme.

- Adopt the Material for MkDocs theme for a modern, responsive design.
- Remove broken links and unused plugins from mkdocs.yml.
- Relocate the site logo to docs/assets for proper loading.
- Remove the redundant documentation link from the site footer.
@taylorbobaylor

Copy link
Copy Markdown
Contributor Author

@ncipollina - Docs can be viewed on my fork for now: https://taylorbobaylor.github.io/cdk-constructs/

@ncipollina
ncipollina requested a review from Copilot July 10, 2025 11:51

This comment was marked as outdated.

@ncipollina ncipollina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, nice work!!! Copilot made some suggestions and I have a few observations:

On the docs home page:

  • Title is duplicated:
image * The emojis that were in the document have been repleced with text: image

@taylorbobaylor

Copy link
Copy Markdown
Contributor Author

Looks like it was still deploying the old documentation but I have made requested changes and looks to be deploying the actual material for mkdocs now: https://taylorbobaylor.github.io/cdk-constructs/

@ncipollina
ncipollina requested a review from Copilot July 10, 2025 17:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project’s documentation from Jekyll to Material for MkDocs, streamlines configuration, fixes asset paths, enhances page layouts with emojis, and adds a new GitHub Actions workflow to deploy the MkDocs site.

  • Updated the .csproj to point to the new icon location under docs/assets.
  • Added mkdocs.yml with Material theme settings and removed Jekyll’s _config.yml.
  • Revised documentation pages to use .md links and emoji-enhanced headings.
  • Introduced a GitHub Actions workflow for building and deploying the MkDocs site.

Reviewed Changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/LayeredCraft.Cdk.Constructs/LayeredCraft.Cdk.Constructs.csproj Adjusted icon asset path to docs/assets/icon.png
mkdocs.yml New MkDocs configuration using Material theme and plugins
docs/index.md Updated navigation links to include .md extensions
docs/constructs/static-site.md Enhanced features list with emojis and corrected internal links
docs/constructs/lambda-function.md Enhanced features list with emojis and corrected internal links
docs/constructs/dynamodb-table.md Enhanced features list with emojis and corrected internal links
docs/assets/css/style.scss Switched SCSS import for the new theme
docs/_config.yml Removed old Jekyll configuration
.github/workflows/mkdocs-material-gh-pages.yml New workflow to build and deploy the MkDocs site
Comments suppressed due to low confidence (2)

.github/workflows/mkdocs-material-gh-pages.yml:2

  • The workflow currently only runs on pushes to main. To support manual execution as described in the PR notes, add a workflow_dispatch: trigger under on:.
on:

mkdocs.yml:12

  • [nitpick] The copyright year is set to 2024. Consider updating this to the current year (2025) to keep the documentation up to date.
copyright: Copyright © 2024 LayeredCraft Team

---

@import "minima";
@import "{{ site.theme }}";

Copilot AI Jul 10, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a Liquid template tag ({{ site.theme }}) inside an SCSS file will not be processed by the MkDocs SASS compiler. You should import the actual theme SCSS file path (e.g., @import "material";) or adjust your build to preprocess Liquid before SASS.

Suggested change
@import "{{ site.theme }}";
@import "material";

Copilot uses AI. Check for mistakes.

@ncipollina ncipollina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Nice work!!!

@ncipollina
ncipollina merged commit 168fa66 into LayeredCraft:main Jul 10, 2025
1 check passed
@ncipollina

Copy link
Copy Markdown
Contributor

@all-contributors please add @taylorbobaylor for doc

@allcontributors

Copy link
Copy Markdown
Contributor

@ncipollina

I've put up a pull request to add @taylorbobaylor! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants