Mkdocs#17
Conversation
- Adopt the Material for MkDocs theme for a modern, responsive design. - Remove broken links and unused plugins from mkdocs.yml. - Relocate the site logo to docs/assets for proper loading. - Remove the redundant documentation link from the site footer.
|
@ncipollina - Docs can be viewed on my fork for now: https://taylorbobaylor.github.io/cdk-constructs/ |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Looks like it was still deploying the old documentation but I have made requested changes and looks to be deploying the actual material for mkdocs now: https://taylorbobaylor.github.io/cdk-constructs/ |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project’s documentation from Jekyll to Material for MkDocs, streamlines configuration, fixes asset paths, enhances page layouts with emojis, and adds a new GitHub Actions workflow to deploy the MkDocs site.
- Updated the
.csprojto point to the new icon location underdocs/assets. - Added
mkdocs.ymlwith Material theme settings and removed Jekyll’s_config.yml. - Revised documentation pages to use
.mdlinks and emoji-enhanced headings. - Introduced a GitHub Actions workflow for building and deploying the MkDocs site.
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/LayeredCraft.Cdk.Constructs/LayeredCraft.Cdk.Constructs.csproj | Adjusted icon asset path to docs/assets/icon.png |
| mkdocs.yml | New MkDocs configuration using Material theme and plugins |
| docs/index.md | Updated navigation links to include .md extensions |
| docs/constructs/static-site.md | Enhanced features list with emojis and corrected internal links |
| docs/constructs/lambda-function.md | Enhanced features list with emojis and corrected internal links |
| docs/constructs/dynamodb-table.md | Enhanced features list with emojis and corrected internal links |
| docs/assets/css/style.scss | Switched SCSS import for the new theme |
| docs/_config.yml | Removed old Jekyll configuration |
| .github/workflows/mkdocs-material-gh-pages.yml | New workflow to build and deploy the MkDocs site |
Comments suppressed due to low confidence (2)
.github/workflows/mkdocs-material-gh-pages.yml:2
- The workflow currently only runs on pushes to
main. To support manual execution as described in the PR notes, add aworkflow_dispatch:trigger underon:.
on:
mkdocs.yml:12
- [nitpick] The copyright year is set to 2024. Consider updating this to the current year (2025) to keep the documentation up to date.
copyright: Copyright © 2024 LayeredCraft Team
| --- | ||
|
|
||
| @import "minima"; | ||
| @import "{{ site.theme }}"; |
There was a problem hiding this comment.
Using a Liquid template tag ({{ site.theme }}) inside an SCSS file will not be processed by the MkDocs SASS compiler. You should import the actual theme SCSS file path (e.g., @import "material";) or adjust your build to preprocess Liquid before SASS.
| @import "{{ site.theme }}"; | |
| @import "material"; |
|
@all-contributors please add @taylorbobaylor for doc |
|
I've put up a pull request to add @taylorbobaylor! 🎉 |


Pull Request
Summary
✅ Checklist
Related Issues or PRs
Closes #...
Notes for Reviewers