Skip to content

[core] Add some startup sanity checks for NMs#9901

Open
WinterSolstice8 wants to merge 1 commit into
LandSandBoat:basefrom
WinterSolstice8:lotto_nm_sanity_checks
Open

[core] Add some startup sanity checks for NMs#9901
WinterSolstice8 wants to merge 1 commit into
LandSandBoat:basefrom
WinterSolstice8:lotto_nm_sanity_checks

Conversation

@WinterSolstice8

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR will inform us of some badly hooked up NMs at startup

This is how I found Peg Powler was missing a PH. I (and others if they want to) will go through this list and fix things in different PRs to reduce the count.

It seems this a mix of misclassified spawntypes, unimplemented NMs and/or unimplemented copies of NMs.

Currently, this PR will only check if the NMs are spawnable. I might have another PR that checks if the phList mobs are not spawnable in any way as well but I think that is less likely.

Steps to test these changes

CI passes

@WinterSolstice8 WinterSolstice8 force-pushed the lotto_nm_sanity_checks branch from 0c22b00 to 0e2bd75 Compare April 30, 2026 22:17
@WinterSolstice8 WinterSolstice8 force-pushed the lotto_nm_sanity_checks branch from 0e2bd75 to 8de2b36 Compare May 1, 2026 01:18
@WinterSolstice8

Copy link
Copy Markdown
Contributor Author

#9903 should have reduced the error count by one. rebased.

@WinterSolstice8

Copy link
Copy Markdown
Contributor Author

#9906 should also reduce error count by one

@WinterSolstice8 WinterSolstice8 force-pushed the lotto_nm_sanity_checks branch 2 times, most recently from 30f9966 to cd19002 Compare May 7, 2026 12:48
@github-actions github-actions Bot added the stale label May 22, 2026
@WinterSolstice8 WinterSolstice8 added hold On hold, pending further action/info and removed stale labels May 22, 2026
@LandSandBoat LandSandBoat deleted a comment from github-actions Bot May 27, 2026
@WinterSolstice8 WinterSolstice8 force-pushed the lotto_nm_sanity_checks branch from cd19002 to 9ca483c Compare June 23, 2026 16:17
@WinterSolstice8 WinterSolstice8 force-pushed the lotto_nm_sanity_checks branch from 9ca483c to 35298a3 Compare June 23, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold On hold, pending further action/info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants