[core] Add some startup sanity checks for NMs#9901
Open
WinterSolstice8 wants to merge 1 commit into
Open
Conversation
0c22b00 to
0e2bd75
Compare
Xaver-DaRed
approved these changes
Apr 30, 2026
0e2bd75 to
8de2b36
Compare
Contributor
Author
|
#9903 should have reduced the error count by one. rebased. |
Contributor
Author
|
#9906 should also reduce error count by one |
30f9966 to
cd19002
Compare
4 tasks
cd19002 to
9ca483c
Compare
9ca483c to
35298a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR will inform us of some badly hooked up NMs at startup
This is how I found Peg Powler was missing a PH. I (and others if they want to) will go through this list and fix things in different PRs to reduce the count.
It seems this a mix of misclassified spawntypes, unimplemented NMs and/or unimplemented copies of NMs.
Currently, this PR will only check if the NMs are spawnable. I might have another PR that checks if the phList mobs are not spawnable in any way as well but I think that is less likely.
Steps to test these changes
CI passes