Skip to content

[lua] Assault Excavation Duty migration#10558

Open
Nobutadas wants to merge 1 commit into
LandSandBoat:basefrom
Nobutadas:assault-excavation-duty-migration
Open

[lua] Assault Excavation Duty migration#10558
Nobutadas wants to merge 1 commit into
LandSandBoat:basefrom
Nobutadas:assault-excavation-duty-migration

Conversation

@Nobutadas

@Nobutadas Nobutadas commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Migrates Excavation Duty to the new framework following PR #10364 for Leujaoam Cleansing

I have a follow-up PR for bug fixes and nerfs as soon as this clears. I just wanted to split the PR so it was easier to review.

Steps to test these changes

Run Excavation Duty assault.

@Nobutadas Nobutadas force-pushed the assault-excavation-duty-migration branch 2 times, most recently from a061b4b to f715020 Compare July 9, 2026 21:28
Comment thread scripts/zones/Lebros_Cavern/IDs.lua Outdated
mob =
{
VOLCANIC_BOMB = GetFirstID('Volcanic_Bomb'),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical order. We've been through this

@Nobutadas Nobutadas Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted.
I had it split because after migrations are complete, everything below VOLCANIC_BOMB will be deleted. Won't do that in the future.

@Nobutadas Nobutadas force-pushed the assault-excavation-duty-migration branch from f715020 to c567881 Compare July 9, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants