Skip to content

[Combat] Add physical checks to nullification and absobption, convert Spikes, and audit some Ammo Additional effects#10542

Merged
Xaver-DaRed merged 6 commits into
LandSandBoat:basefrom
Xaver-DaRed:arrows
Jul 10, 2026
Merged

[Combat] Add physical checks to nullification and absobption, convert Spikes, and audit some Ammo Additional effects#10542
Xaver-DaRed merged 6 commits into
LandSandBoat:basefrom
Xaver-DaRed:arrows

Conversation

@Xaver-DaRed

@Xaver-DaRed Xaver-DaRed commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Allows nullification and absorbtion global functions to check for physical attack types.
    • By extension, edits all their usages.
  • Converts mob stupid spike logic to a less stupid global system.
  • Kills another magic.lua function
  • AE system: Added parameters for even more flexibility.
  • Changes to existing items: Use new system. Some values are unreliable. Real data is non-existant. Retail testing needed.
  • Changes to non-existing items: They now do something?

Steps to test these changes

Review by commit.
This touches a lot of stuff. Have faith.

@Xaver-DaRed Xaver-DaRed force-pushed the arrows branch 4 times, most recently from 3b7fbfb to 10fa279 Compare July 8, 2026 19:40
Comment thread scripts/items/fire_arrow.lua Outdated
@Xaver-DaRed Xaver-DaRed force-pushed the arrows branch 3 times, most recently from a4a93ce to b0b9fd2 Compare July 9, 2026 00:10
@Butsuon

Butsuon commented Jul 9, 2026

Copy link
Copy Markdown

#7899

Some data has already been collected on many of the ammos for their damage and scaling. Their magic accuracy hasn't been confirmed, but damage values are known.

@Butsuon

Butsuon commented Jul 9, 2026

Copy link
Copy Markdown

It looks like I forgot to add it, but last I tested it looked like Holy Bolts capped at dINT+40 as well.

@Xaver-DaRed Xaver-DaRed force-pushed the arrows branch 4 times, most recently from 04e5a8e to 602557d Compare July 9, 2026 12:50
@Xaver-DaRed Xaver-DaRed changed the title [Combat] Audit some Ammo Additional effects [Combat] Add physical checks to mullification and absobption, convert Spikes, and audit some Ammo Additional effects Jul 9, 2026
@Xaver-DaRed Xaver-DaRed changed the title [Combat] Add physical checks to mullification and absobption, convert Spikes, and audit some Ammo Additional effects [Combat] Add physical checks to nullification and absobption, convert Spikes, and audit some Ammo Additional effects Jul 9, 2026
@Xaver-DaRed Xaver-DaRed force-pushed the arrows branch 3 times, most recently from e485661 to 1149689 Compare July 9, 2026 18:40
@Xaver-DaRed Xaver-DaRed marked this pull request as ready for review July 9, 2026 18:41
@Xaver-DaRed

Copy link
Copy Markdown
Contributor Author

YOLO

@Xaver-DaRed Xaver-DaRed merged commit ebb2284 into LandSandBoat:base Jul 10, 2026
12 checks passed
@Xaver-DaRed Xaver-DaRed deleted the arrows branch July 10, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants