[lua] Assault exit event bug fix and event skipped

[Nobutadas]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

1. In the new Assault framework, if the Assault ends by a teammate OR through the timeout, if the player is in the event, the exit event doesn't fire until the player leaves their current event. This PR will instead have the player quit the event, wait 2 seconds (retail delay), and then fire the exit event.

The way I implemented this is a :release() then a 2 second wait until the exit event to mimic the retail delay. If I didn't have that 2 second wait, the exit event never fires and you are stuck in the assault. With this implementation, technically, the player can spam "enter" to re-enter the event. I think a future PR will also need to freeze or lock the player during all of this.

2. Adds event skipped to the rune of release.

Video of ending Assault while in an event: https://youtu.be/-1ZAWkKUkQc
Video of Event Skipped: https://youtu.be/YHvsnZkPV50

Steps to test these changes

Go into one of the new assaults, beat it, sit at the rune of release until the timer runs out in that event.

[Xaver-DaRed]

if member:getID() ~= player:getID()
I dont understand this check

[Nobutadas]

At this point, the player is wrapping up the Rune of Release event. The exit event (102) will fire automatically after the Rune of Release event ends a fraction of a second later. If I don't have this check, the player who triggered the Rune of Release gets an "Event Skipped." text.

I attached a screenshot of what it looks like on LSB without that check.

[Nobutadas]

I can add a comment explaining it.

[Nobutadas]

Added comment and adjusted timer to 1.

Timer of 1 throws a harmless map warning.
[map][warn] Invalid GP_CLI_COMMAND_EVENTEND packet from Test: Event ID mismatch 102 != 100. (anonymous-namespace'::ValidatedPacketHandler:220) Timer of 500 throws another harmless map warning. [map][warn] Invalid GP_CLI_COMMAND_EVENTEND packet from Test: Not in an event. (anonymous-namespace'::ValidatedPacketHandler:220)

[Nobutadas]

Capture: https://drive.google.com/file/d/1bkNLWRf9gSB_2WaxQ1nq_F4sMu-4bDNJ/view?usp=sharing

[sruon]

Quick look at the capture shows the following exchange

sync 4251 at 22:52:26.761 EVENTUCOFF sent to client with Mode 25602 (telling it to cancel event 100)
sync 4252 at 22:52:26.828 (+67ms) EVENTEND sent to server with eventId 100 and magic cancel option
sync 4253 at 22:52:27.517 (+689ms) EVENT sent to client with eventId 102 (the actual expel)

It's not really a 2s delay, it's the server waiting for the acknowledgment of the event being cancelled client side before sending the expel.

I need a little time to think through it.