Skip to content

[lua,sql,cpp][module] Summoner era modules and adjustments#10479

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
CriticalXI:summoner_adjust
Jul 10, 2026
Merged

[lua,sql,cpp][module] Summoner era modules and adjustments#10479
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
CriticalXI:summoner_adjust

Conversation

@CriticalXI

@CriticalXI CriticalXI commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds several files to revert some Summoner specific behavior such as spirit perpetuation cost and merit adjustments.
  • Adds a new server setting to disable Summoner casting time merits to avoid a major C++ adjustment to be able to module this change.

Steps to test these changes

  • Load up modules and server setting
  • Change to summoner
  • See the blood pacts and spirit MP costs are properly set to their listed values

@zach2good

zach2good commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I was just talking to Winter about this. Migrating the table to Lua... for what reason?

(I'm aware the reason is very likely so you can module over it)

In isolation, this is making this function 100x slower, with no opportunity for me to apply additional layers of caching on top:

// NOTE: Is safe to call on invalid tables, will ultimately return nil
// NOTE: Intentionally NOT cached - would break Mocking/Spy etc.
auto findGlobalLuaFunction(const std::string& funcName) -> sol::function

I think it's reasonable to submit the era module alongside these sorts of changes, so we don't just have to accept codebase churn for seemingly no reason

EDIT: I have read the PR body, you did say module, but this still counts as empty prep work and churn without the module itself 🤷

@CriticalXI

Copy link
Copy Markdown
Contributor Author

I'm taking a look at another way to go about the module we need to change perpetuation costs so we don't have to touch core code. I'll get the module put together and update this with what I can come up with.

@CriticalXI CriticalXI marked this pull request as draft July 3, 2026 21:25
@CriticalXI CriticalXI changed the title [lua, cpp] Migrate perpetuation cost table to lua [lua,sql,cpp][module] Summoner era modules and adjustments Jul 5, 2026
@CriticalXI

Copy link
Copy Markdown
Contributor Author

I've reworked the PR completely to be for Summoner modules. I was able to come up with a way to update perpetuation costs without ripping out the formula to lua.

@CriticalXI CriticalXI marked this pull request as ready for review July 5, 2026 23:07
@Xaver-DaRed Xaver-DaRed enabled auto-merge July 9, 2026 23:16
@Xaver-DaRed Xaver-DaRed merged commit 19a6b35 into LandSandBoat:base Jul 10, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants