[lua,sql,cpp][module] Summoner era modules and adjustments#10479
Conversation
|
I was just talking to Winter about this. Migrating the table to Lua... for what reason? (I'm aware the reason is very likely so you can module over it) In isolation, this is making this function 100x slower, with no opportunity for me to apply additional layers of caching on top: // NOTE: Is safe to call on invalid tables, will ultimately return nil
// NOTE: Intentionally NOT cached - would break Mocking/Spy etc.
auto findGlobalLuaFunction(const std::string& funcName) -> sol::functionI think it's reasonable to submit the era module alongside these sorts of changes, so we don't just have to accept codebase churn for seemingly no reason EDIT: I have read the PR body, you did say module, but this still counts as empty prep work and churn without the module itself 🤷 |
|
I'm taking a look at another way to go about the module we need to change perpetuation costs so we don't have to touch core code. I'll get the module put together and update this with what I can come up with. |
ddacc87 to
3f37917
Compare
|
I've reworked the PR completely to be for Summoner modules. I was able to come up with a way to update perpetuation costs without ripping out the formula to lua. |
3f37917 to
716edd3
Compare
I affirm:
What does this pull request do?
Steps to test these changes