Fix GPA Calc by adding IIFE. Add Webpack to bundle NPM Packages#27
Draft
RachitKeertiDas wants to merge 3 commits into
Draft
Fix GPA Calc by adding IIFE. Add Webpack to bundle NPM Packages#27RachitKeertiDas wants to merge 3 commits into
RachitKeertiDas wants to merge 3 commits into
Conversation
This allows script to run multiple times on the same page without errors.
Add Webpack to allow use of NPM Modules Use Webpack config to specify a target for the each HTML page. npx webpack builds the pages into build/ Modified HTML pages to link to js files in build/ Modify .gitignore to include build/
Add Post-Install Hooks for automatic build on install. Modify Pre-Commit Hook to check for successful builds. Modify Installation Instructions to include `npm install`. Add Note about Development Instructions.
RachitKeertiDas
marked this pull request as ready for review
December 6, 2020 18:18
RachitKeertiDas
marked this pull request as draft
December 9, 2020 05:29
Collaborator
Contributor
Author
|
Ah yes, this. I have been slightly busy on this. Also haven't been able to figure out the regression yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be helpful to allow using NPM Packages using a bundler like Webpack.
Webpackneeds to be set up to bundle the.jsfiles with the imported packages.To allow for easy installation, I would recommend adding a post install hook to run
webpackimmediately after clone.Also, we could set up a
pre-commithook to check that commits build successfully.Task List
webpack.This PR Is currently a WIP.
htmlfiles to source the built files.Please review and provide suggestions.
Update:
Update2: