Prohibit HTTP GET parameters for jsessionid#7676
Conversation
|
I don't see a jsessionid on the url anymore but I can't actually log in via HTTP. (Yes, require HTTPS is unchecked in site settings) |
I think that's the awkward compromise. You can still log in, but only if you're using a browser that doesn't already have the Secure setting on its session cookie. |
Ok. I tried it in an incognito window but I probably went to HTTPS first and got the secure cookie. I was able to log in if I went straight to HTTP in a fresh incognito window. |
|
I opened firefox to repro something weird I was seeing on chrome - after not using firefox for at least a few weeks. |
This must be a different sequence than the one I used to repro. You shouldn't be able to hit the instance itself on HTTP at this point - the WAF should be doing a redirect. Regardless, @labkey-mohara @labkey-jony if you see this again in develop or 26.6+ please let me know. This change should prevent the URL approach. |
Rationale
Servers that run both HTTP and HTTPS can end up choosing to send
jsessionidvalues as GET parameters, because they may have an HTTP cookie that set toSecure. In scenarios like this, we want to be sure that we end up redirecting the client to HTTPS. We don't want session IDs to ever leak onto the URL.Changes
Tasks 📍
application.propertiesTest AutomationVerify Fix