Add mixed atom/orbital projection API, kline styling and layered scatter plotting for bands - #3
Open
LRH123LRH123 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Band:_orbital_name_to_index,_get_spd_masks,_parse_orbital_selector,_parse_atom_selector,_normalize_mixed_projection_spec, and_format_orbital_selector_labelto convert human-friendly selectors into boolean masks._sum_mixed_projections,export_mixed_projections_data, and public plotting methodplot_mixed_projectionsthat acceptprojection_specin both dict and list styles and produce labeled projections and an optionalPBAND_mixed.datexport.kline_styleandkline_widthparameters to_get_kticks,_get_kticks_hse,_get_kticks_unfold,plot_plain, and callers to control vertical k-line linestyle/width, and addedkline_style/kline_widthto the publicband_plainfunction instandard.py._plot_projected_general_newwhich supportsscatter_mode='flattened'(original behavior) and'layered'(per-channel draw order) and exposed it viaplot_mixed_projections; also introducedscatter_modeand color handling in theband_mixed_projectionshelper instandard.py.linewidthvalues and ensured unfolding logic integrates with the new projection/export code.Testing
Codex Task