[Bug][Update] Bump HCOMM version to v9.0.0 to fix SEGFAULT and match CANN 9.0 in v0.4.5#267
Open
marcobarlo wants to merge 1 commit into
Open
[Bug][Update] Bump HCOMM version to v9.0.0 to fix SEGFAULT and match CANN 9.0 in v0.4.5#267marcobarlo wants to merge 1 commit into
marcobarlo wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the third_party/hcomm subproject commit from d3cae0c5402398bb86e3a591e7d19706c0a1e552 to 09a304742994c603879a57291579afd52c3126d9. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
matthewygf
approved these changes
Jul 13, 2026
matthewygf
left a comment
Collaborator
There was a problem hiding this comment.
lgtm ! Let's merge once we create the release @chloroethylene
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #262
Bump
third_party/hcommfrom v8.5.0 (d3cae0c) to v9.0.0 (09a3047) so HCCL public headers match the CANN 9.0 toolkit and the shippedlibhccl_plfon Ascend 910B. CANN v9.0 is the default shippend CANN for vLLM >= v0.20.This PR is a submodule pointer only. It does not add CMake ABI / LTO overrides; the existing per-TU
_GLIBCXX_USE_CXX11_ABI=0guards incsrc/hccl/{hccl_utils,hccl_agent,bindings}.cppalready force the old libstdc++ ABI required bylibhccl_plf.Problem
hccl_npu_commscompiles against HCOMM headers (HcclIpAddress,hrtRaGetDeviceIP, …) and links the systemlibhccl_plf. On hosts upgraded to CANN 9.0, that shared library matches HCOMM v9 layout (includingHcclIpAddress/ Eid-related fields).Keeping the submodule on v8.5 while linking CANN 9.0
libhccl_plfcreates a silent struct / ABI mismatch on types that embedstd::stringand are passed instd::vector<hccl::HcclIpAddress>. At runtime this surfaces as a segfault insideGetLocalIpv4()when callinghrtRaGetDeviceIPduring HCCL agent setup (PD buffer register / peer init). Prefiller and decoder then never establish a healthy PD path.Fix
Point
third_party/hcommat tag v9.0.0 so include paths used bycsrc/hcclagree with the toolkit binary. No other source changes are required for this crash.After the bump, rebuild
hccl_npu_commsso objects are compiled against the new headers before linkinglibhccl_plf.Test plan
git submodule update --init third_party/hcomm→git describe --tagsreportsv9.0.0rm -rf build && pip install --no-build-isolation -e .PD_INSTANCE=both: prefiller + decoder serve/v1/modelsRegistered memory with HCCLon prefiller and decoder TP0Segmentation fault/SIGSEGVaround HCCL agent init in prefiller or decoder logs