Fix Coveralls Issue that Caused Coverage Drops#1851
Draft
AkramBitar wants to merge 1 commit into
Draft
Conversation
AkramBitar
changed the title
Signed-off-by: AkramBitar <akram@il.ibm.com>
AkramBitar
force-pushed
the
fix/coveralls-parallel-finalization-race
branch
from
d1ce587 to
fa61f7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix integration test coverage attribution
Integration tests live in their own Go module, so the token/... code they exercise is treated as a dependency and isn't instrumented by default — its coverage was being dropped from the report.
Adding -coverpkg=github.com/LFDT-Panurus/panurus/... to GINKGO_TEST_OPTS scopes coverage to the root module so it's counted again.