Validate and Verify Audit Information Before Registration#1789
Open
AkramBitar wants to merge 1 commit into
Open
Validate and Verify Audit Information Before Registration#1789AkramBitar wants to merge 1 commit into
AkramBitar wants to merge 1 commit into
Conversation
a09c67b to
c2d783f
Compare
9d5bf64 to
3de3fe8
Compare
1caab0b to
60bbad1
Compare
…ipient identity registration Signed-off-by: AkramBitar <akram@il.ibm.com>
b9c4308 to
d9781cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RegisterRecipientIdentityaccepted recipient identity data without structural validation, so malformed or incompleteRecipientDatacould be persisted into the audit trail.Solution
A structural validation in
token/services/identity/wallet, run before the existingMatchIdentitycryptographic binding:10 B … 1 MiB, audit info≤ 50 KB. (The identity cap is generous so composite identities — MultiSig/Policy aggregate several inner identities — and larger X509/Idemix payloads are never falsely rejected; it only rejects pathological multi-MB blobs.)≤ 256 B(non-composite types only).≤ 512 B(non-composite types only).Deserializer.MatchIdentity(identity ↔ audit info).Composite types (MultiSig, HTLC, Policy) have no enrollment ID / revocation handle, so steps 4–5 are skipped for them in one place.