limit the number of tokens a transaction retrieves and locks#1707
Open
HayimShaul wants to merge 4 commits into
Open
limit the number of tokens a transaction retrieves and locks#1707HayimShaul wants to merge 4 commits into
HayimShaul wants to merge 4 commits into
Conversation
HayimShaul
force-pushed
the
1641_bound_work_by_request
branch
4 times, most recently
from
dda132d to
142170c
Compare
Contributor
|
Hi @HayimShaul , should these changes apply also to |
HayimShaul
force-pushed
the
1641_bound_work_by_request
branch
2 times, most recently
from
0a0b6ca to
2662935
Compare
adecaro
reviewed
Jun 1, 2026
adecaro
reviewed
Jun 1, 2026
adecaro
reviewed
Jun 1, 2026
adecaro
reviewed
Jun 1, 2026
Contributor
|
@HayimShaul , don't we need to enforce limit also at the fetcher level A more general question, if we say that we can only load 100 tokens at the time from the storage, what if for these 100 tokens the selection request cannot be satisfied, but if had picked the tokens differently we would have. We might reject requests that can be satisfied. |
Contributor
Author
done |
HayimShaul
force-pushed
the
1641_bound_work_by_request
branch
3 times, most recently
from
4ac2576 to
079ec93
Compare
HayimShaul
force-pushed
the
1641_bound_work_by_request
branch
from
cb59a41 to
3778cd1
Compare
AkramBitar
force-pushed
the
1641_bound_work_by_request
branch
3 times, most recently
from
39378e4 to
1bdbe20
Compare
HayimShaul
force-pushed
the
1641_bound_work_by_request
branch
from
95ef2b6 to
319c6fb
Compare
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
HayimShaul
force-pushed
the
1641_bound_work_by_request
branch
from
2b91b1f to
8f6abe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solve issue #1641