Skip to content

Repaired and updated the visattributes of the slice test geometry.#2074

Merged
tvami merged 1 commit into
trunkfrom
iss1880-repairvis-slicetest
Jun 15, 2026
Merged

Repaired and updated the visattributes of the slice test geometry.#2074
tvami merged 1 commit into
trunkfrom
iss1880-repairvis-slicetest

Conversation

@cjbarton151

Copy link
Copy Markdown
Contributor

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #2069, which exists as a sub-issue of #1976. I initially intended to file this as a sub-issue of #1880 but changed my mind. Realizing now that I forgot to update the branch name as well... But that's fine.

Not a complicated PR, just adding visattributes in the slice test geometry where they were previously missing or outdated. I think this should mark the end of the visattributes repairs, unless someone really has demand for one of the old geometries to be updated to the current format.

Check List

  • I successfully compiled ldmx-sw with my developments.
  • I read, understood and follow the coding rules.
  • I ran my developments and the following shows that they are successful.

I ran the reduced CI test locally with no issues, and loaded the updated files into the visualizer without issues.

Before:
image

After:
image

The taggers aren't visible in the second picture but that's because the silicon material color is set to black... Again, hindsight 20/20, this might not have been the optimal choice for rendering. They reappear easily when color mode is set to 'region' with the new visattributes, though:

image

@cjbarton151 cjbarton151 self-assigned this Jun 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Validation Results

Some validation samples failed! ❌

Sample Status
cascade_history ✅ PASS
deep_ecal_gun ✅ PASS
eat_signal ✅ PASS
ecal_pn ✅ PASS
hcal ✅ PASS
inclusive ✅ PASS
kaon_enhanced ✅ PASS
signal ✅ PASS
signal_target_al ✅ PASS
target_genie ✅ PASS
target_pn_lyso ✅ PASS
wab_lhe ✅ PASS
it_pileup ❌ FAIL
reduced_ldmx ❌ FAIL (211 histograms failed KS test) (artifact)
target_ti_en ❌ FAIL (386 histograms failed KS test) (artifact)

reduced_ldmx:

  • 211 plots failed the KS test against gold.
  • Text Differences Between Logs (258319 lines differ)
  • Log character count differs by 0% (gold=33510645, new=33428186); within tolerance
  • Timing anomaly for reduced_ldmx: new=212s vs gold=1881s (-88%, tolerance 10%)
  • Timing for reduced_ldmx: gold=1881s, new=212s

target_ti_en:

  • 386 plots failed the KS test against gold.
  • Text Differences Between Logs (6916 lines differ)
  • Log character count differs by 4%: gold=377322, new=393097
  • Timing for target_ti_en: gold=3247s, new=3099s
  • Timing within 4% of gold (tolerance 10%)

cascade_history:

  • Text Differences Between Logs (2 lines differ)
  • Timing for cascade_history: gold=6401s, new=6200s
  • Timing within 3% of gold (tolerance 10%)

deep_ecal_gun:

  • Text Differences Between Logs (20 lines differ)
  • Timing for deep_ecal_gun: gold=3976s, new=4114s
  • Timing within 3% of gold (tolerance 10%)

eat_signal:

  • Timing for eat_signal: gold=1542s, new=1512s
  • Timing within 1% of gold (tolerance 10%)

ecal_pn:

  • Text Differences Between Logs (46 lines differ)
  • Log character count differs by 0% (gold=21521436, new=21521584); within tolerance
  • Timing for ecal_pn: gold=7360s, new=6847s
  • Timing within 6% of gold (tolerance 10%)

hcal:

  • Text Differences Between Logs (2 lines differ)
  • Timing for hcal: gold=854s, new=856s
  • Timing within 0% of gold (tolerance 10%)

inclusive:

  • Text Differences Between Logs (30 lines differ)
  • Log character count differs by 0% (gold=21025667, new=21025815); within tolerance
  • Timing for inclusive: gold=7065s, new=6871s
  • Timing within 2% of gold (tolerance 10%)

kaon_enhanced:

  • Text Differences Between Logs (50 lines differ)
  • Log character count differs by 0% (gold=8843741, new=8843889); within tolerance
  • Timing for kaon_enhanced: gold=2867s, new=3041s
  • Timing within 6% of gold (tolerance 10%)

signal:

  • Text Differences Between Logs (32 lines differ)
  • Log character count differs by 0% (gold=16413458, new=16413606); within tolerance
  • Timing for signal: gold=1255s, new=1203s
  • Timing within 4% of gold (tolerance 10%)

signal_target_al:

  • Text Differences Between Logs (42 lines differ)
  • Log character count differs by 0% (gold=16793364, new=16793512); within tolerance
  • Timing regression for signal_target_al: new=1082s vs gold=653s (+65%, tolerance 10%)
  • Timing for signal_target_al: gold=653s, new=1082s

target_genie:

  • Text Differences Between Logs (4494 lines differ)
  • Timing regression for target_genie: new=6616s vs gold=5487s (+20%, tolerance 10%)
  • Timing for target_genie: gold=5487s, new=6616s

target_pn_lyso:

  • Text Differences Between Logs (48 lines differ)
  • Log character count differs by 0% (gold=5130723, new=5130871); within tolerance
  • Timing for target_pn_lyso: gold=6580s, new=6299s
  • Timing within 4% of gold (tolerance 10%)

wab_lhe:

  • Text Differences Between Logs (48 lines differ)
  • Log character count differs by 0% (gold=13180210, new=13180363); within tolerance
  • Timing for wab_lhe: gold=7412s, new=6992s
  • Timing within 5% of gold (tolerance 10%)

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

Validation Results

Some validation samples failed! ❌

Sample Status
cascade_history ✅ PASS
deep_ecal_gun ✅ PASS
eat_signal ✅ PASS
ecal_pn ✅ PASS
hcal ✅ PASS
inclusive ✅ PASS
kaon_enhanced ✅ PASS
signal ✅ PASS
signal_target_al ✅ PASS
target_genie ✅ PASS
target_pn_lyso ✅ PASS
wab_lhe ✅ PASS
it_pileup ❌ FAIL
reduced_ldmx ❌ FAIL (211 histograms failed KS test) (artifact)
target_ti_en ❌ FAIL (386 histograms failed KS test) (artifact)

reduced_ldmx:

  • 211 plots failed the KS test against gold.
  • Text Differences Between Logs (258319 lines differ)
  • Log character count differs by 0% (gold=33510645, new=33428186); within tolerance
  • Timing anomaly for reduced_ldmx: new=212s vs gold=1881s (-88%, tolerance 10%)
  • Timing for reduced_ldmx: gold=1881s, new=212s

target_ti_en:

  • 386 plots failed the KS test against gold.
  • Text Differences Between Logs (6916 lines differ)
  • Log character count differs by 4%: gold=377322, new=393097
  • Timing for target_ti_en: gold=3247s, new=3099s
  • Timing within 4% of gold (tolerance 10%)

cascade_history:

  • Text Differences Between Logs (2 lines differ)
  • Timing for cascade_history: gold=6401s, new=6200s
  • Timing within 3% of gold (tolerance 10%)

deep_ecal_gun:

  • Text Differences Between Logs (20 lines differ)
  • Timing for deep_ecal_gun: gold=3976s, new=4114s
  • Timing within 3% of gold (tolerance 10%)

eat_signal:

  • Timing for eat_signal: gold=1542s, new=1512s
  • Timing within 1% of gold (tolerance 10%)

ecal_pn:

  • Text Differences Between Logs (46 lines differ)
  • Log character count differs by 0% (gold=21521436, new=21521584); within tolerance
  • Timing for ecal_pn: gold=7360s, new=6847s
  • Timing within 6% of gold (tolerance 10%)

hcal:

  • Text Differences Between Logs (2 lines differ)
  • Timing for hcal: gold=854s, new=856s
  • Timing within 0% of gold (tolerance 10%)

inclusive:

  • Text Differences Between Logs (30 lines differ)
  • Log character count differs by 0% (gold=21025667, new=21025815); within tolerance
  • Timing for inclusive: gold=7065s, new=6871s
  • Timing within 2% of gold (tolerance 10%)

kaon_enhanced:

  • Text Differences Between Logs (50 lines differ)
  • Log character count differs by 0% (gold=8843741, new=8843889); within tolerance
  • Timing for kaon_enhanced: gold=2867s, new=3041s
  • Timing within 6% of gold (tolerance 10%)

signal:

  • Text Differences Between Logs (32 lines differ)
  • Log character count differs by 0% (gold=16413458, new=16413606); within tolerance
  • Timing for signal: gold=1255s, new=1203s
  • Timing within 4% of gold (tolerance 10%)

signal_target_al:

  • Text Differences Between Logs (42 lines differ)
  • Log character count differs by 0% (gold=16793364, new=16793512); within tolerance
  • Timing regression for signal_target_al: new=1082s vs gold=653s (+65%, tolerance 10%)
  • Timing for signal_target_al: gold=653s, new=1082s

target_genie:

  • Text Differences Between Logs (4494 lines differ)
  • Timing regression for target_genie: new=6616s vs gold=5487s (+20%, tolerance 10%)
  • Timing for target_genie: gold=5487s, new=6616s

target_pn_lyso:

  • Text Differences Between Logs (48 lines differ)
  • Log character count differs by 0% (gold=5130723, new=5130871); within tolerance
  • Timing for target_pn_lyso: gold=6580s, new=6299s
  • Timing within 4% of gold (tolerance 10%)

wab_lhe:

  • Text Differences Between Logs (48 lines differ)
  • Log character count differs by 0% (gold=13180210, new=13180363); within tolerance
  • Timing for wab_lhe: gold=7412s, new=6992s
  • Timing within 5% of gold (tolerance 10%)

@tvami

tvami commented Jun 14, 2026

Copy link
Copy Markdown
Member

Failure for IT PU is not related, I made an issue
#2075

@tvami tvami requested a review from tomeichlersmith June 15, 2026 15:17
@tvami tvami merged commit f5abe17 into trunk Jun 15, 2026
35 of 41 checks passed
@tvami tvami deleted the iss1880-repairvis-slicetest branch June 15, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repairing VisAttributes in the slice test geometry

3 participants