Repaired and updated the visattributes of the slice test geometry.#2074
Merged
Conversation
Contributor
Validation ResultsSome validation samples failed! ❌
|
1 similar comment
Contributor
Validation ResultsSome validation samples failed! ❌
|
tvami
approved these changes
Jun 14, 2026
Member
|
Failure for IT PU is not related, I made an issue |
tomeichlersmith
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #2069, which exists as a sub-issue of #1976. I initially intended to file this as a sub-issue of #1880 but changed my mind. Realizing now that I forgot to update the branch name as well... But that's fine.
Not a complicated PR, just adding visattributes in the slice test geometry where they were previously missing or outdated. I think this should mark the end of the visattributes repairs, unless someone really has demand for one of the old geometries to be updated to the current format.
Check List
I ran the reduced CI test locally with no issues, and loaded the updated files into the visualizer without issues.
Before:

After:

The taggers aren't visible in the second picture but that's because the silicon material color is set to black... Again, hindsight 20/20, this might not have been the optimal choice for rendering. They reappear easily when color mode is set to 'region' with the new visattributes, though: