refactor: move shared lib to experiments/shared/, remove cross-experiment symlinks#20
Open
iheitlager wants to merge 4 commits into
Open
refactor: move shared lib to experiments/shared/, remove cross-experiment symlinks#20iheitlager wants to merge 4 commits into
iheitlager wants to merge 4 commits into
Conversation
- Move lib/bench.sh from 001_hello_world to experiments/shared/lib/ - Update symlinks in 001, 002, 003 to point to ../shared/lib - Copy 001_hello_world/leg3_wasmtime into 003_wasm_compile/rust-hello/ (removes cross-experiment symlink dependency) - Update Makefile, benchmark.sh, .gitignore for rust -> rust-hello rename Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The refactor/shared-lib commit regressed the Makefile by losing the individual build-js, build-py, build-rust sub-targets and their cp-to-build/ steps. Also switches venv creation from python3 -m venv to uv, and restructures tests into source/build/runtime sections with consistent naming. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… 0.17 - Update app.py to use class-based IncomingHandler API (spin-sdk 3.x) - Update spin.toml build command to use componentize-py on PATH (no hardcoded venv path, no -d wit flag — spin-sdk provides WIT) - Add --all-features to python-raw build for @unstable WIT annotations - Pin requirements: componentize-py>=0.17,<0.18 + spin-sdk>=3.4,<4 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restore the test naming convention from 5ebe81b, grouped by component (js-spin, py-raw, py-spin, rust) with source → build → runtime order. Add AS tests as 016–019. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/bench.shfrom001_hello_world/lib/toexperiments/shared/lib/../shared/libinstead of../001_hello_world/lib003_wasm_compile/rust-hello/(was a symlink to001_hello_world/leg3_wasmtime)rust→rust-hellorenameBefore
After
Test plan
bats tests/test_helpers.bats— 17/17)bats tests/— 14/14)🤖 Generated with Claude Code