feat(models): extend model contract for tool calling (#156)#177
Merged
Conversation
Add provider-neutral ToolDef, ToolCall, ToolResult types and extend GenerateRequest/GenerateResponse/ChatMessage/GenerateMeta so the agent loop can express tool definitions, tool-use responses, and token usage. Closes #156 Co-authored-by: Cursor <cursoragent@cursor.com>
ReviewGate [PASS]
|
Automated reviewSummaryEnhancements to model contract, tool definitions, and token metrics. Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/modelswithToolDef,ToolCall, andToolResulttypes.Tools/ToolChoicetoGenerateRequest,ToolCalls/StopReasontoGenerateResponse,ToolResultstoChatMessage, andPromptTokens/CompletionTokenstoGenerateMeta.internal/models/doc.goanddocs/DESIGN_DOC.md§12.2 F.GenerateMeta(already parsed; now surfaced).Closes #156
Test plan
go test ./internal/models/... -racego test ./... -racego vet ./...gofmt -l .(clean)GenerateRequest{Model, Messages}call sites compile unchangedToolChoicezero value resolves to"auto"viaToolChoiceOrDefault()Made with Cursor