test(native): assert registry Dispatch parity with DispatchOperations#155
Merged
Conversation
Replace the Registry.Dispatch switch with a dispatchHandlers map as the single source of truth for non-shell operations. Derive DispatchOperations from handler keys and add drift tests so new handlers without catalog metadata fail CI. Closes #130. Co-authored-by: Cursor <cursoragent@cursor.com>
ReviewGate [PASS]
|
Automated reviewSummaryComprehensive refactor of native operations with good test coverage. Findings
|
Use O(1) dispatchHandlers lookup in OperationKnown, add pull_request.fetch and offline echo/identity dispatch tests, and drop redundant handler-slice parity test. Drift guard verified manually for orphan handler/catalog cases. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registry.Dispatchswitch with adispatchHandlersmap as the single source of truth for non-shell native operations.DispatchOperationsfrom handler keys so runtime dispatch and policy-lint metadata cannot drift silently.TestRegistryDispatchMatchesCatalog, dispatch smoke/failure-path tests, andpull_request.fetchoffline contract coverage.Closes #130.
Test plan
go test ./internal/tools/native/... -racemake ci(verify-fmt, vet, test with race detector)dispatchHandlerswithout anoperationCatalogentry failsTestRegistryDispatchMatchesCatalogoperationCatalogentry without a handler failsTestRegistryDispatchMatchesCatalog