test: NC-2 — degrade TenantObj.id (codegen-guard canary must go RED)#4
Closed
Kyzgor wants to merge 2 commits into
Closed
test: NC-2 — degrade TenantObj.id (codegen-guard canary must go RED)#4Kyzgor wants to merge 2 commits into
Kyzgor wants to merge 2 commits into
Conversation
…in CI The pinned generator 6.2.1 cannot read the OpenAPI 3.1.0 spec served at api.permit.io: it regenerates an all-`any`, type-erased client (247 of 319 type files) yet exits 0, masked by --skip-validate-spec. Running `yarn generate-openapi-client` today silently replaces the typed client with `any`. Re-pin the generator to 7.12.0 — the first 3.1-native line that produces a fully typed client — and add a CI codegen guard that regenerates from a pinned 3.1.0 fixture through the real pipeline and fails if any type collapses to all-`any`. The guard runs in its own Java-provisioned job, off the test suite. The committed client under src/openapi/ is intentionally left unchanged: this restores and guards the toolchain. Re-baselining the generated client against the current spec is a separate, larger change. Refs permitio#130
Deliberately empties TenantObj.properties.id in the fixture so generator 7.12.0 emits a bare `id: any` (no index signature). Check (a) still passes; the new canary must fail in CI (proves the hardened canary additions fire). NOT for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negative control. Empties TenantObj.id in the fixture so 7.12.0 emits a bare
id: any; check (a) passes and the new canary must fail (proves the hardened canary additions fire). NOT for merge — close after CI.