fix: re-pin openapi generator to 3.1-native 7.12.0 and guard codegen in CI#1
Closed
Kyzgor wants to merge 1 commit into
Closed
fix: re-pin openapi generator to 3.1-native 7.12.0 and guard codegen in CI#1Kyzgor wants to merge 1 commit into
Kyzgor wants to merge 1 commit into
Conversation
Kyzgor
force-pushed
the
codegen/repin-generator-3.1
branch
from
f0b6607 to
ec781cd
Compare
…in CI The pinned generator 6.2.1 cannot read the OpenAPI 3.1.0 spec served at api.permit.io: it regenerates an all-`any`, type-erased client (247 of 319 type files) yet exits 0, masked by --skip-validate-spec. Running `yarn generate-openapi-client` today silently replaces the typed client with `any`. Re-pin the generator to 7.12.0, the first 3.1-native line that regenerates a typed client (named properties instead of `any`; 2 known allOf+default residuals remain, allow-listed and tracked for the re-baseline), and add a CI codegen guard that regenerates from a pinned 3.1.0 fixture through the real pipeline and fails if any type collapses to all-`any`. The guard runs in its own Java-provisioned job, off the test suite. The committed client under src/openapi/ is intentionally left unchanged: this restores and guards the toolchain. Re-baselining the generated client against the current spec is a separate, larger follow-up. Fixes permitio#130
Kyzgor
force-pushed
the
codegen/repin-generator-3.1
branch
from
ec781cd to
4993c34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal CI-verification PR for the Stage-1 codegen fix (lever B for permitio#130) before the upstream PR.
What changes
openapitools.json: generator pin6.2.1 -> 7.12.0(first 3.1-native line that types the spec).scripts/check-codegen.mjs: codegen guard — regenerates from a pinned 3.1.0 fixture through the real pipeline, fails if any type collapses to all-any(allow-listing the 2 known residual files).src/tests/codegen/fixtures/openapi-3.1.0.json: the pinned fixture..github/workflows/ci.yaml: a separate Java-provisionedcodegen-guardjob.Scope:
src/openapi/is intentionally frozen (PATCH; no consumer breaks). Re-baselining the generated client is a separate change.Purpose of this PR: confirm the
codegen-guardjob runs green in the real CI environment (setup-java provisioning, Maven download, separate-job wiring) before opening the upstream PR.