fix: send Anthropic Messages effort#296
Draft
musnows wants to merge 1 commit into
Draft
Conversation
0713998 to
620d569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output_config.effortfor Anthropic Messages adaptive thinking requestsoffmapped tothinking: { type: "disabled" }/v1/messagesreasoning effortRoot cause
The UI and runtime preserved the selected reasoning effort, but the Anthropic Messages adapter collapsed every non-off effort into
thinking: { type: "adaptive" }. That enabled adaptive thinking, but dropped the concrete effort level, so compatible upstream services could show an empty reasoning strength.Anthropic's current docs state that adaptive thinking is enabled with
thinking: { type: "adaptive" }, while thinking depth is controlled by theoutput_config.effortparameter:Fixes #281
Validation
npm --prefix kun test -- tests/model-client.test.tsnpm --prefix kun run build