build: repair package-lock.json and ignore claude worktrees#272
Open
whitelonng wants to merge 18 commits into
Open
build: repair package-lock.json and ignore claude worktrees#272whitelonng wants to merge 18 commits into
whitelonng wants to merge 18 commits into
Conversation
…entering fix: center placeholder text and input content vertically in composer input
fix: preserve sidebar chat history when viewing scheduled tasks
…ar-schedule-bug Revert "fix: preserve sidebar chat history when viewing scheduled tasks"
…-placeholder-centering Revert "fix: center placeholder text and input content vertically in composer input"
-- Commit By Codex --
…bility-badges [codex] Compact provider model capability badges
…t-model-capability-badges Revert "[codex] Compact provider model capability badges"
The lockfile was missing @napi-rs/canvas optional dependency entries declared by pdfjs-dist. This is a repository-hygiene fix, not a release-blocker: CI (release.yml) runs npm ci on Linux and tolerates the missing platform-optional entries there, but local installs on other platforms (e.g. macOS with npm 11) fail npm ci with EUSAGE and pdfjs-dist ends up absent from node_modules, breaking the write-pdf-text-service test which imports pdfjs-dist/legacy/build/pdf.mjs. Regenerated lockfile entries via npm install --package-lock-only. Minimal patch: adds @napi-rs/canvas platform packages and removes an orphaned pend entry; touches no other package versions. Also add .claude/worktrees/ to .gitignore to prevent transient agent worktrees from being committed or scanned by ESLint.
whitelonng
force-pushed
the
fix/lockfile-and-gitignore
branch
from
ee9d1a6 to
ebf1220
Compare
whitelonng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two repository-hygiene improvements on
develop. Not a release-blocker — see note below.1. Repair
package-lock.json(local install hygiene)pdfjs-distdeclares@napi-rs/canvasas an optional dependency, but the lockfile only listed the declaration without the resolution entries for the actual platform packages.Impact is environment-dependent:
release.ymlrunsnpm cion Linux runners, where npm tolerates the missing platform-optional entries and the build succeeds.npm cifails withEUSAGE("Missing: @napi-rs/canvas@0.1.100 from lock file"),pdfjs-distis absent fromnode_modules, and thewrite-pdf-text-servicetest fails withCannot find package 'pdfjs-dist/legacy/build/pdf.mjs'.The same broken lockfile is present on both
masteranddevelop(identical content/hash), so this fix applies cleanly to either branch.Fix: Regenerated lockfile entries via
npm install --package-lock-only --no-audit --ignore-scripts. Minimal and scoped:@napi-rs/canvas@0.1.100platform packages (android-arm64, darwin-arm64, darwin-x64, linux-, win32-) and theirnode-gyp-buildtoolchain dependencypend@1.2.0entry (no longer referenced) and the staleoptionalDependenciesblock onpdfjs-dist2. Ignore
.claude/worktrees/Transient agent worktrees under
.claude/worktrees/were not gitignored. Never tracked by git, but ESLint was scanning them and producing duplicate warnings (e.g.ConnectPhoneView.tsxwarnings appeared for both the main checkout and each worktree copy).Fix: Add
.claude/worktrees/to.gitignore. Scoped to theworktrees/subdirectory only — does not affect.claude/commands/,.claude/settings.json, or other tracked files.Verification
npm cisucceeds locally on macOS (947 packages, no EUSAGE) — was failing beforenode_modules/pdfjs-dist/legacy/build/pdf.mjsexistsnpx vitest run src/main/services/write-pdf-text-service.test.tspasses — was failing beforenpm run lint— 0 errors; warnings reduced from 25 → 18 (worktree duplicates eliminated)npm run typecheckpassesdevelop(no conflicts)Note on scope
This is a hygiene improvement, not a critical bug fix. The lockfile mismatch does not affect releases (CI's
npm cion Linux succeeds). The value is in unblocking local development on platforms/environments wherenpm cifails. Happy to close if maintainers consider this too minor.