fix(build): ship multi-size Windows .ico for crisp small icons#264
Open
whitelonng wants to merge 1 commit into
Open
fix(build): ship multi-size Windows .ico for crisp small icons#264whitelonng wants to merge 1 commit into
whitelonng wants to merge 1 commit into
Conversation
The Windows build pointed at a single 1024px PNG, so Explorer and the desktop downscaled it for the small/tile views and the icon looked blurry (KunAgent#222). Ship a multi-size build/icon.ico (16/24/32/48/64/72/96/ 128/256) generated from the rounded kun_mac.png so each shell size has a native bitmap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kun_mac.png), so Windows downscaled it on the fly for the small-icon / tile views in Explorer and on the desktop, leaving the icon blurry.build/icon.icocontaining 16/24/32/48/64/72/96/128/256 px bitmaps, generated from the same roundedkun_mac.pngso each shell size has a crisp native bitmap.win.iconnow points atbuild/icon.ico; macOS/Linux icons are untouched.Regenerating the .ico
Test plan
build/icon.icocontains 9 sizes (16→256, 32bpp).