Skip to content

feat: add warning modal before deleting connected email account#603

Open
KratikaShukla07 wants to merge 1 commit into
Kuldeeep18:mainfrom
KratikaShukla07:feat/lo-122-delete-email-warning-modal
Open

feat: add warning modal before deleting connected email account#603
KratikaShukla07 wants to merge 1 commit into
Kuldeeep18:mainfrom
KratikaShukla07:feat/lo-122-delete-email-warning-modal

Conversation

@KratikaShukla07

@KratikaShukla07 KratikaShukla07 commented Jul 7, 2026

Copy link
Copy Markdown

🔗 Related Issue

Closes #559

📝 Summary of Changes

  • Added a warning confirmation modal before deleting a connected email account.
  • Updated the confirmation message to clearly inform users that deleting the sender account will pause all campaigns using it.
  • Preserved the existing delete functionality after user confirmation.

🏷️ Type of Change

  • 🎨 UI / UX Improvement

🧪 Testing

  • Verified the warning message is displayed before deletion.
  • Confirmed the existing delete flow remains unchanged after confirmation.

📸 Screenshots

N/A

✅ Checklist

  • No merge conflicts
  • Changes follow the project guidelines
  • Related issue linked
  • Tested locally

Summary by CodeRabbit

  • Bug Fixes
    • Updated the removal confirmation message for connected email accounts to clearly warn that deleting the sender account will immediately pause any campaigns scheduled to send from it.

@KratikaShukla07

Copy link
Copy Markdown
Author

Hi @Kuldeeep18,

I have implemented the requested warning confirmation message for deleting a connected email account as described in Issue #559.

Kindly review my PR when you have time.

Thank you!

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b58429f-830b-4aac-ad7e-bb4e94ef50d2

📥 Commits

Reviewing files that changed from the base of the PR and between 4a33158 and f97f740.

📒 Files selected for processing (1)
  • frontend/settings.html

📝 Walkthrough

Walkthrough

The confirmation modal message displayed when deleting a connected email account in settings.html was updated to warn that removal will immediately pause all campaigns scheduled to send from it, replacing the previous shorter confirmation text.

Changes

Modal warning text update

Layer / File(s) Summary
Update delete confirmation message
frontend/settings.html
The showConfirmModal warning text for deleting a connected email account is updated to state that deletion immediately pauses campaigns scheduled to send from it; modal title, confirm label, and callback logic are unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main UI change to the connected email delete flow.
Linked Issues check ✅ Passed The change updates the connected email delete warning in settings.html to match the requested confirmation modal behavior.
Out of Scope Changes check ✅ Passed Only the connected email delete confirmation text in settings.html changed, so no out-of-scope work is evident.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (ai_padded_prose). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LO-122 [Easy]: Display Warning Modal when Deleting a Connected Email Account

1 participant