Provision pnpm via Corepack and pin the version#22
Merged
Conversation
Replace the npm-based pnpm bootstrap in the Docker assets stage with Corepack (ships with Node, no npm needed) and pin the pnpm version via package.json's packageManager field for reproducible builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the only direct
npmusage in the build and makes the pnpm toolchain reproducible, in response to the upcoming npm v12 breaking changes.The project already uses pnpm for all front-end dependency work, and pnpm disables dependency lifecycle scripts by default — so the headline npm v12 change (install scripts off by default) doesn't affect us. The one remaining npm touchpoint was the Docker assets stage bootstrapping pnpm with
npm install -g pnpm. This PR replaces that with Corepack and pins the pnpm version.Changes
package.json— add"packageManager": "pnpm@10.33.0"(matches the currently used pnpm and thepnpm-lock.yamlv9.0 lockfile). Single source of truth for the pnpm version across local, CI, and Docker.Dockerfile— replacenpm install -g pnpmwithcorepack enablein the Node assets stage. Corepack ships with Node and auto-activates the pinned version, so no npm is needed. Thepnpm install --frozen-lockfile --ignore-scriptsstep is unchanged.CLAUDE.md— document the Corepack-based pnpm provisioning and version-pinning workflow.Verification
package.jsonvalidated as JSON.pnpm install --frozen-lockfile --ignore-scripts(same flags as Docker) succeeds and reportsDone … using pnpm v10.33.0, confirming the pin agrees with the lockfile.Note: the Docker image build itself wasn't run in this environment, but Corepack is bundled in
node:22-bookworm-slim.https://claude.ai/code/session_01F94J3DuNM4dVjcDConFyHJ
Generated by Claude Code