feat: support spm #2
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Swift Package Manager (SPM) support by adding a Package.swift file and updating the .gitignore to exclude SPM-related files. The review feedback highlights a necessary correction to the publicHeadersPath to ensure headers are correctly located, a suggestion to lower the minimum iOS version for broader compatibility, and a recommendation to remove a default macro definition that could cause conflicts and inconsistency with other distribution methods.
| path: "YYText", | ||
| publicHeadersPath: "include", | ||
| cSettings: [ | ||
| .define("YYTEXT_ENABLE_SHORTHAND", to: "1") |
There was a problem hiding this comment.
Enabling YYTEXT_ENABLE_SHORTHAND by default changes the library's behavior compared to the CocoaPods installation. This macro enables shorthand property names which might conflict with other code in a user's project. It is generally better to keep the default behavior consistent with other package managers by not defining this macro here.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
No description provided.