Skip to content

squid:S1170 - Public constants should be declared "static final" rather than merely "final" #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SosoTughushi wants to merge 6 commits into
base: master
Choose a base branch
from
Open

squid:S1170 - Public constants should be declared "static final" rather than merely "final" #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5c939b
Corrected Travis reference in README
Feb 18, 2016
229c9a0
Fixed MessageFormat which is not working when the same argument is r…
sureshbabuinfo Jun 8, 2016
7beae23
Merge pull request #551 from sureshbabuinfo/master
Jun 9, 2016
c48cd5c
Revert "Fixed MessageFormat which is not working when the same argum…
Jun 9, 2016
8285f3d
Merge pull request #552 from davidsowerby/revert-551-master
Jun 9, 2016
db7d463
Fixed rule 'Public constants and fields initialized at declaration sh…
SosoTughushi Jul 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

![License](http://img.shields.io/:license-apache-blue.svg)
[![Gitter](https://badges.gitter.im/davidsowerby/krail.svg)](https://gitter.im/davidsowerby/krail?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
[![Build Status](https://travis-ci.org/davidsowerby/krailkrail.svg?branch=master)](https://travis-ci.org/davidsowerby/krail)
[![Build Status](https://travis-ci.org/davidsowerby/krail.svg?branch=master)](https://travis-ci.org/davidsowerby/krail)
[![Coverage Status](https://coveralls.io/repos/github/davidsowerby/krail/badge.svg?branch=master)](https://coveralls.io/github/davidsowerby/krail?branch=master)

Krail provides a framework for rapid Java web development by combining Vaadin, Guice, Apache Shiro, Apache Commons Configuration and others. For more information, see the comprehensive [Tutorial](http://krail.readthedocs.org/en/master/), which also makes a reasonable demo. (You can clone directly from the [Tutorial repo](https://github.com/davidsowerby/krail-tutorial))
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/uk/q3c/krail/core/view/Grid3x3ViewBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
import static com.google.common.base.Preconditions.checkArgument;

public class Grid3x3ViewBase extends ViewBase {
private final float[] defaultColumnWidths = new float[]{1f, 1f, 1f};
private final float[] defaultRowHeights = new float[]{1f, 1f, 1f};
private static final float[] defaultColumnWidths = new float[]{1f, 1f, 1f};
private static final float[] defaultRowHeights = new float[]{1f, 1f, 1f};
private GridLayout grid;

@Inject
Expand Down
42 changes: 21 additions & 21 deletions src/test/java/uk/q3c/krail/core/navigate/StrictURIFragmentHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,27 +27,27 @@
@GuiceContext({})
public class StrictURIFragmentHandlerTest {

final String view = "view1";
final String view_ = "view1/";
final String view_p = "view1/a=b";
final String view_p2 = "view1/a=b/year=1970";
final String view_p2m1 = "view1/a=b/year=";
final String view_p2m2 = "view1/a=b/=1970";
final String view_p2m3 = "view1/a=b/1970";
final String view_p2m5 = "view1/=b/year=1970";
final String view_p2m6 = "view1/a=/year=1970";

final String subView = "view1/subView";
final String subView_ = "view1/subView/";
final String subView_p = "view1/subView/a=b";
final String subView_p2 = "view1/subView/a=b/year=1970";
final String dbl = "view//subView";

final String home = "";
final String home_p = "a=b";
final String home_p2 = "a=b/year=1970";

final String subView_p2_bang = "!view1/subView/a=b/year=1970";
static final String view = "view1";
static final String view_ = "view1/";
static final String view_p = "view1/a=b";
static final String view_p2 = "view1/a=b/year=1970";
static final String view_p2m1 = "view1/a=b/year=";
static final String view_p2m2 = "view1/a=b/=1970";
static final String view_p2m3 = "view1/a=b/1970";
static final String view_p2m5 = "view1/=b/year=1970";
static final String view_p2m6 = "view1/a=/year=1970";

static final String subView = "view1/subView";
static final String subView_ = "view1/subView/";
static final String subView_p = "view1/subView/a=b";
static final String subView_p2 = "view1/subView/a=b/year=1970";
static final String dbl = "view//subView";

static final String home = "";
static final String home_p = "a=b";
static final String home_p2 = "a=b/year=1970";

static final String subView_p2_bang = "!view1/subView/a=b/year=1970";

@Inject
StrictURIFragmentHandler uriHandler;
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/uk/q3c/krail/core/navigate/sitemap/DefaultSitemapServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ public class DefaultSitemapServiceTest {

static VaadinService vaadinService;
static ResourceUtils resourceUtils = new DefaultResourceUtils();
private final int FILE_NODE_COUNT = 4;
private final int DIRECT_NODE_COUNT = 2;
private final int STANDARD_NODE_COUNT = 5;
private static final int FILE_NODE_COUNT = 4;
private static final int DIRECT_NODE_COUNT = 2;
private static final int STANDARD_NODE_COUNT = 5;
@Inject
DefaultSitemapService service;
@Inject
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/uk/q3c/krail/core/ui/ScopedUITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
public class ScopedUITest {

static int connectCount;
protected final String baseUri = "http://example.com";
protected static final String baseUri = "http://example.com";
ScopedUI ui;
@Mock
Navigator navigator;
Expand Down