Skip to content

fix(mcp): allow multi-line description in capture_inbox #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Koopa0 merged 1 commit into from
Jul 2, 2026
Merged

fix(mcp): allow multi-line description in capture_inbox #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/mcp/capture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func validateCaptureInput(input *CaptureInboxInput) (due *time.Time, rec todo.Re
if goal.ContainsControlChars(input.Title) {
return nil, rec, false, fmt.Errorf("title must not contain control characters")
}
if goal.ContainsControlChars(input.Description) {
if containsProseControlChars(input.Description) {
return nil, rec, false, fmt.Errorf("description must not contain control characters")
}
if input.Energy != nil && *input.Energy != "" && !isValidEnergy(*input.Energy) {
Expand Down
9 changes: 9 additions & 0 deletions internal/mcp/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ func TestCaptureInbox_Validation(t *testing.T) {
}
}

func TestCaptureInbox_MultilineDescription(t *testing.T) {
// Description is multi-line Markdown prose (rendered as paragraphs and
// bullets), so LF/CR/HT are legitimate — same treatment as content body.

@augmentcode augmentcode Bot Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestCaptureInbox_MultilineDescription’s comment mentions allowing LF/CR/HT, but the test input only exercises \n; this could miss a future regression where \r or \t gets rejected despite the intent documented here.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

input := CaptureInboxInput{Title: "ok", Description: "- noticed\n\n- proposal\n\n- value"}
if _, _, _, err := validateCaptureInput(&input); err != nil {
t.Fatalf("multi-line description rejected: %v", err)
}
}

// --- plan_day ---

func TestPlanDay_Validation(t *testing.T) {
Expand Down
Loading