fix: more robust HTTPRoute validation#7913
Open
programmer04 wants to merge 1 commit intomainfrom
Open
Conversation
programmer04
added
area/maintenance
programmer04
force-pushed
the
fix/validation
branch
2 times, most recently
from
4d15041 to
93de45a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7913 +/- ##
=======================================
+ Coverage 78.4% 80.9% +2.4%
=======================================
Files 222 222
Lines 20780 20780
=======================================
+ Hits 16312 16817 +505
+ Misses 3437 2896 -541
- Partials 1031 1067 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7913 +/- ##
=====================================
Coverage 78.4% 78.4%
=====================================
Files 222 222
Lines 20791 20791
=====================================
+ Hits 16307 16315 +8
+ Misses 3452 3446 -6
+ Partials 1032 1030 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
programmer04
force-pushed
the
fix/validation
branch
from
93de45a to
96014fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
More robust validation for
HTTPRoute, when an unsupported feature is used, and the route refers to existing and non-existingGateway, it will be rejected.Which issue this PR fixes:
See this comment for more context
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR