Skip to content

Add TODO notes for ARM register access#9

Merged
Ko496-glitch merged 4 commits into
mainfrom
copilot/add-read-write-implementation
May 14, 2026
Merged

Add TODO notes for ARM register access#9
Ko496-glitch merged 4 commits into
mainfrom
copilot/add-read-write-implementation

Conversation

Copilot AI commented May 12, 2026

Copy link
Copy Markdown
Contributor
  • Re-run baseline build/configure checks to confirm current status
  • Apply clang-format to register comment updates
  • Re-run targeted build/configure checks
  • Reply to PR comment with commit reference

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request
Agent-Logs-Url: https://github.com/Ko496-glitch/phosphoros/sessions/f8210a09-d271-4aa8-9603-0054d29b068a

Co-authored-by: Ko496-glitch <191642578+Ko496-glitch@users.noreply.github.com>
Copilot AI changed the title [WIP] Add read/write implementation for AArch64 registers Document x86 vs AArch64 register access considerations May 12, 2026
Copilot AI requested a review from Ko496-glitch May 12, 2026 03:25
@Ko496-glitch

Copy link
Copy Markdown
Owner

@copilot so for shared api for read/write maybe something like HAL would make sense ?

Copilot AI commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot so for shared api for read/write maybe something like HAL would make sense ?

Yes — a HAL-style boundary makes sense. The public read/write API can stay shared while a per-arch (and per-regset) backend handles the actual ptrace/regset mechanics and sub-register masking.

@Ko496-glitch

Copy link
Copy Markdown
Owner

@copilot you can just add inlibe comments in the include/libkdb/registers.hpp and registers.cpp and mark it as ready for review
dont write too much just mention as a TODO section of ARM implementation

Agent-Logs-Url: https://github.com/Ko496-glitch/phosphoros/sessions/e182c01b-9cc7-46c0-8903-0377f7d3ce15

Co-authored-by: Ko496-glitch <191642578+Ko496-glitch@users.noreply.github.com>

Copilot AI commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

@copilot you can just add inlibe comments in the include/libkdb/registers.hpp and registers.cpp and mark it as ready for review
dont write too much just mention as a TODO section of ARM implement...

Added concise ARM TODO notes in registers.hpp and new registers.cpp. Commit: e50e0c5. No UI changes.

Copilot AI changed the title Document x86 vs AArch64 register access considerations Add TODO notes for ARM register access May 14, 2026
@Ko496-glitch Ko496-glitch marked this pull request as ready for review May 14, 2026 03:08
@Ko496-glitch

Copy link
Copy Markdown
Owner

@copilot make sure we have to clang-format on the comments

Agent-Logs-Url: https://github.com/Ko496-glitch/phosphoros/sessions/7b3a2cc6-b5f7-4f62-800b-c44fb8fd38cd

Co-authored-by: Ko496-glitch <191642578+Ko496-glitch@users.noreply.github.com>

Copilot AI commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

@copilot make sure we have to clang-format on the comments

Ran clang-format on the comment block; update is in commit de64734. No UI changes.

@Ko496-glitch Ko496-glitch merged commit 24da59f into main May 14, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

read/write implementation

2 participants