Add TODO notes for ARM register access#9
Merged
Conversation
Closed
Agent-Logs-Url: https://github.com/Ko496-glitch/phosphoros/sessions/f8210a09-d271-4aa8-9603-0054d29b068a Co-authored-by: Ko496-glitch <191642578+Ko496-glitch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add read/write implementation for AArch64 registers
Document x86 vs AArch64 register access considerations
May 12, 2026
Owner
|
@copilot so for shared api for read/write maybe something like HAL would make sense ? |
Contributor
Author
Yes — a HAL-style boundary makes sense. The public read/write API can stay shared while a per-arch (and per-regset) backend handles the actual ptrace/regset mechanics and sub-register masking. |
Owner
|
@copilot you can just add inlibe comments in the |
Agent-Logs-Url: https://github.com/Ko496-glitch/phosphoros/sessions/e182c01b-9cc7-46c0-8903-0377f7d3ce15 Co-authored-by: Ko496-glitch <191642578+Ko496-glitch@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Document x86 vs AArch64 register access considerations
Add TODO notes for ARM register access
May 14, 2026
Owner
|
@copilot make sure we have to clang-format on the comments |
Agent-Logs-Url: https://github.com/Ko496-glitch/phosphoros/sessions/7b3a2cc6-b5f7-4f62-800b-c44fb8fd38cd Co-authored-by: Ko496-glitch <191642578+Ko496-glitch@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.