[regsiters controll process_struct -> registers sync#10
Open
Ko496-glitch wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the process and register management system in the
libkdblibrary. The main changes include improved integration between theprocessandregistersclasses, new methods for reading and writing register values, and the implementation of register read/write logic. These changes lay the groundwork for more robust debugging and process control functionality.Integration and API Improvements:
processclass now owns a unique pointer to aregistersobject, which is initialized in its constructor. This allows each process to manage its own register state more effectively. (include/libkdb/process.hppinclude/libkdb/process.hppL28-R30)processfor reading all registers, retrieving register values, and writing to the user area, providing a clearer and more usable API for interacting with process registers. (include/libkdb/process.hppinclude/libkdb/process.hppR46-R49)Register Class Refactoring:
registersclass to separate theuser data_andprocess *proc_members, improving code clarity and maintainability. (include/libkdb/registers.hppinclude/libkdb/registers.hppL13-R14)valuetype alias for register values by properly closing the type list with a semicolon. (include/libkdb/registers.hppinclude/libkdb/registers.hppL23-R24)Implementation of Register Read/Write Logic:
src/registers.cpp) that defines the logic for reading and writing register values based on their type and size, including error handling for unexpected register sizes and mismatches. (src/registers.cppsrc/registers.cppR1-R54)Header Inclusion and Dependency Updates:
process.hppto ensure theregistersclass is properly referenced, supporting the new ownership model. (include/libkdb/process.hppinclude/libkdb/process.hppR4-L6)