Skip to content

Add support for Cerulean Sonar ROV Locator#112

Open
NickNothom wants to merge 2 commits into
Knio:masterfrom
NickNothom:master
Open

Add support for Cerulean Sonar ROV Locator#112
NickNothom wants to merge 2 commits into
Knio:masterfrom
NickNothom:master

Conversation

@NickNothom
Copy link
Copy Markdown

The Cerulean Sonar ROV Locator is an underwater localization system.

This commit adds our "RTH" message

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 18, 2020

Coverage Status

Coverage increased (+0.006%) to 98.083% when pulling bc49070 on NickNothom:master into 4527cf4 on Knio:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.006%) to 98.083% when pulling 1d060f0 on NickNothom:master into 4527cf4 on Knio:master.

@Knio
Copy link
Copy Markdown
Owner

Knio commented Jun 22, 2020

Hi, thanks for the addition. Can you provide a sample sentence and add it to a unit test? Something like https://github.com/Knio/pynmea2/blob/master/test/test_rdi.py would be enough.

@NickNothom
Copy link
Copy Markdown
Author

@Knio Let me know if that is sufficient

@NickNothom
Copy link
Copy Markdown
Author

@Knio Please let me know if I need to do anything else to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants