Fix/build by JMauclair · Pull Request #15 · Klickbee/klickbee-crm

JMauclair · 2025-11-28T09:46:09Z

No description provided.

Reviewed-on: https://git.stralya.com/Klickbee/klickbee-crm/pulls/7

…Password required in login schema

…ter clarity

…s and priority

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…Klickbee/klickbee-crm into fix/build

Copilot

Pull request overview

This pull request addresses build issues by refactoring form components and schemas. The changes primarily involve migrating from Formik to react-hook-form, improving type safety, and fixing schema definitions across various form components.

Key Changes:

Migrated form input components (TextInput, TextareaInput, SelectInput, CheckboxInput, InputWithDropDown) from Formik's Field-based approach to native HTML elements with forwardRef support for react-hook-form compatibility
Enhanced type safety in TodoForm.tsx and MeetingForm.tsx by adding explicit type assertions and definitions
Removed unused usersLoading prop from TodoModel component
Updated Zod schemas to improve validation logic

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/feature/todo/components/TodoModel.tsx	Removed unused `usersLoading` prop from TodoForm component
src/feature/todo/components/TodoForm.tsx	Added type safety with Status and Priority types, added type assertions for dropdown onChange handlers, and reformatted code
src/feature/meetings/components/MeetingForm.tsx	Updated Zod schema by removing `.default()` and `.or(z.literal(""))` chains, simplified status type conversion logic
src/components/ui/TextareaInput.tsx	Migrated from Formik Field component to native textarea with forwardRef for react-hook-form compatibility
src/components/ui/TextInput.tsx	Migrated from Formik Field component to native input with forwardRef for react-hook-form compatibility
src/components/ui/SelectInput.tsx	Migrated from Formik Field component to native select with forwardRef for react-hook-form compatibility
src/components/ui/InputWithDropDown.tsx	Migrated from Formik Field components to native input/select elements with ref support
src/components/ui/CheckboxInput.tsx	Migrated from Formik Field component to native checkbox input with forwardRef for react-hook-form compatibility
src/components/AuthModel/page.tsx	Updated Zod schema definitions for email validation and login schema fields

Comments suppressed due to low confidence (3)

src/feature/todo/components/TodoModel.tsx:9

Unused import toast.

import toast from "react-hot-toast"

src/feature/todo/components/TodoModel.tsx:12

Unused import useCompaniesStore.

import { useCompaniesStore } from "@/feature/companies/stores/useCompaniesStore"

src/feature/todo/components/TodoModel.tsx:25

Unused variable usersLoading.

  const { users, loading: usersLoading, fetchUsers } = useUserStore();

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-28T09:59:51Z


 const baseSchema = z.object({
-  email: z.string().email("Invalid email"),
+  email: z.email("Invalid email"),


The method z.email() does not exist in Zod. It should be z.string().email("Invalid email") to validate email format.

Suggested change

email: z.email("Invalid email"),

email: z.string().email("Invalid email"),

Copilot · 2025-11-28T09:59:51Z

+  name: z.string(),
+  confirmPassword: z.string(),


In the loginSchema, name and confirmPassword fields should be .optional() since they are only required for signup, not login. Without .optional(), these fields will be required for login validation, which is incorrect.

Suggested change

name: z.string(),

confirmPassword: z.string(),

name: z.string().optional(),

confirmPassword: z.string().optional(),

Copilot · 2025-11-28T09:59:52Z

+        step="0.01"
+        min="0"
+        ref={inputRef}
+        className="flex-1 text-sm rounded-l-md px-3 py-2 outline-none [&::-webkit-inner-spin-button]:appearance-none [&:-webkit-outer-spin-button]:appearance-none [appearance:textfield] w-1/4"


Invalid CSS pseudo-class selector. The correct syntax is [&::-webkit-outer-spin-button] (with double colons), not [&:-webkit-outer-spin-button] (single colon). This will cause the style to not be applied correctly.

Suggested change

className="flex-1 text-sm rounded-l-md px-3 py-2 outline-none [&::-webkit-inner-spin-button]:appearance-none [&:-webkit-outer-spin-button]:appearance-none [appearance:textfield] w-1/4"

className="flex-1 text-sm rounded-l-md px-3 py-2 outline-none [&::-webkit-inner-spin-button]:appearance-none [&::-webkit-outer-spin-button]:appearance-none [appearance:textfield] w-1/4"

Copilot · 2025-11-28T09:59:52Z

+    assignedTo: z.string().optional(),
+    linkedTo: z.string().optional(),
+    participants: z.array(z.string().trim().min(1, "Participant name cannot be empty").max(100)),
+    status: z.enum(["scheduled", "confirmed", "cancelled"], { error: "Status is required" }),


The z.enum() configuration object should use required_error or errorMap, not error. The property name error is not valid for Zod's enum options and will not display the custom error message.

Suggested change

status: z.enum(["scheduled", "confirmed", "cancelled"], { error: "Status is required" }),

status: z.enum(["scheduled", "confirmed", "cancelled"], { required_error: "Status is required" }),

Copilot · 2025-11-28T09:59:52Z

-    tags: z.array(z.string().trim().min(1, "Tag cannot be empty").max(30)).default([]),
+    assignedTo: z.string().optional(),
+    linkedTo: z.string().optional(),
+    participants: z.array(z.string().trim().min(1, "Participant name cannot be empty").max(100)),


The participants field should have a .default([]) to handle cases where participants are not provided. Without it, the field will be undefined when not provided, which can cause runtime errors when the code expects an array (e.g., in line 242 where vals.participants.map() is called).

Suggested change

participants: z.array(z.string().trim().min(1, "Participant name cannot be empty").max(100)),

participants: z.array(z.string().trim().min(1, "Participant name cannot be empty").max(100)).default([]),

Copilot · 2025-11-28T09:59:52Z

+    linkedTo: z.string().optional(),
+    participants: z.array(z.string().trim().min(1, "Participant name cannot be empty").max(100)),
+    status: z.enum(["scheduled", "confirmed", "cancelled"], { error: "Status is required" }),
+    tags: z.array(z.string()).optional(),


The tags field should have a .default([]) to ensure it's always an array. Without this, when tags are not provided, the field will be undefined, which can cause issues when the code expects an array.

Suggested change

tags: z.array(z.string()).optional(),

tags: z.array(z.string()).optional().default([]),

github-actions · 2025-11-28T10:57:22Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

…r improved flexibility' (#15) from implement/semantic_release into main Reviewed-on: https://git.stralya.com/Klickbee/klickbee-crm/pulls/15

JMauclair added 5 commits November 28, 2025 09:26

Merge pull request 'implement/ci_cd' (#7) from implement/ci_cd into main

b2aa41d

Reviewed-on: https://git.stralya.com/Klickbee/klickbee-crm/pulls/7

fix: update email validation to use z.email and make name and confirm…

af530be

…Password required in login schema

fix: refine MeetingForm validation and update optional fields for bet…

0a35c59

…ter clarity

fix: enhance TodoForm validation and improve default values for statu…

d49d473

…s and priority

fix: remove unused usersLoading prop from TodoModel component

23d50f6

chatgpt-codex-connector Bot reviewed Nov 28, 2025

View reviewed changes

Comment thread src/components/AuthModel/page.tsx

Comment thread src/feature/meetings/components/MeetingForm.tsx

JMauclair and others added 2 commits November 28, 2025 13:54

Replace Formik UI inputs with native elements

f044b0a

Merge branch 'codex/remove-and-replace-formik' of https://github.com/…

7ec882c

…Klickbee/klickbee-crm into fix/build

JMauclair merged commit e29cd22 into main Nov 28, 2025
1 check passed

JMauclair deleted the fix/build branch November 28, 2025 09:56

JMauclair self-assigned this Nov 28, 2025

JMauclair requested a review from Copilot November 28, 2025 09:56

Copilot started reviewing on behalf of JMauclair November 28, 2025 09:57 View session

Copilot finished reviewing on behalf of JMauclair November 28, 2025 09:58

Copilot AI reviewed Nov 28, 2025

View reviewed changes

github-actions Bot added the released label Nov 28, 2025

Navigation Menu

Uh oh!

Fix/build - #15

Fix/build#15
JMauclair merged 7 commits into
mainfrom
fix/build

JMauclair commented Nov 28, 2025

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

github-actions Bot commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	email: z.email("Invalid email"),
	email: z.string().email("Invalid email"),

	className="flex-1 text-sm rounded-l-md px-3 py-2 outline-none [&::-webkit-inner-spin-button]:appearance-none [&:-webkit-outer-spin-button]:appearance-none [appearance:textfield] w-1/4"
	className="flex-1 text-sm rounded-l-md px-3 py-2 outline-none [&::-webkit-inner-spin-button]:appearance-none [&::-webkit-outer-spin-button]:appearance-none [appearance:textfield] w-1/4"

	status: z.enum(["scheduled", "confirmed", "cancelled"], { error: "Status is required" }),
	status: z.enum(["scheduled", "confirmed", "cancelled"], { required_error: "Status is required" }),

	participants: z.array(z.string().trim().min(1, "Participant name cannot be empty").max(100)),
	participants: z.array(z.string().trim().min(1, "Participant name cannot be empty").max(100)).default([]),

	tags: z.array(z.string()).optional(),
	tags: z.array(z.string()).optional().default([]),

Uh oh!

Conversation

JMauclair commented Nov 28, 2025

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants