fix(task): Render Kanban board when user has zero tasks - #160
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughRefactored the task list rendering logic in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Kanban board disappearing when a user has zero tasks. The
tasks.length === 0check intask-list.tsxwas evaluated before theview === "board"check, so the genericTaskEmptyStatecard always rendered — even in board view.The fix reorders the ternary so
view === "board"is checked first.KanbanBoardnow renders unconditionally in board mode. EachKanbanColumnalready handles its own empty state ("No tasks in {name}" + inline add-task control), so the board degrades gracefully with zero tasks.List view behavior is unchanged —
TaskEmptyState/TaskSearchEmptyStatestill renders when appropriate.Closes #157
Review / Merge checklist
Summary by CodeRabbit