chore: Clean up workspace dependencies and Turbo config (audit session 1) - #159
Merged
KiwiGaze merged 8 commits intoFeb 22, 2026
Merged
Conversation
These packages import 'server-only' but relied on pnpm hoisting. Audit ref: 007 P0-1
Used in vercel-build.sh, 3 Sentry configs, and storage.ts but was missing from cache key computation. Audit ref: 007 P1-3
incremental: true is set but the build info file was never cached, making incremental checks useless across Turbo cache hits. Audit ref: 007 P1-4
Was in turbo.json build.env but missing from @t3-oss/env-nextjs validation. Audit ref: 007 P1-5
test was 'vitest' (watch mode, hangs CI), now 'vitest run --passWithNoTests'. Added lint script to match workspace convention. Audit ref: 007 P2-1
Apps are consumers, not libraries — peerDependencies is semantically meaningless for private app packages. Audit ref: 007 P2-2
Was using pnpm --filter directly, bypassing Turbo task graph and cache. Audit ref: 007 P2-4
- Add explicit dependsOn: [] to root test task - Remove test → test:run indirection in task-group, task-sync, ui Audit ref: 007 P2-5
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThis PR updates dependency declarations and build configuration across the monorepo. It adds "server-only" as a runtime dependency to multiple packages, restructures React dependencies in the chrome extension, introduces a new environment variable for the web app, standardizes test scripts to invoke Vitest directly, updates the root lint:next script to use Turbo, and refines Turbo configuration with additional environment variables and task outputs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements all 8 small-effort (S) findings from the monorepo audit remediation spec (007), covering Session 1 — Mechanical Fixes.
Changes
server-onlyas explicit dependency to 10 packages that relied on pnpm hoistingVERCEL_ENVto rootturbo.jsonglobalEnvfor cache correctness.tsbuildinfointype-checkoutputs so incremental builds survive Turbo cacheNEXT_PUBLIC_MAX_FILE_SIZEtoenv.mjsclient schema for validationai-reviewmanifest — addlintscript, fixtestto not use watch modereact/react-domfrompeerDependenciestodependenciesin Chrome extension (apps don't need peerDeps)lint:nextthrough Turbo for cache benefitstest/test:runtask consistency — add explicitdependsOn: [], removetest → test:runindirection in 3 packagesVerification
Test plan
pnpm lint:fix— no issuespnpm lint:next— now routed through Turbo, passedpnpm type-check:all— 22 packages passedpnpm test:run— 22 packages passedturbo run build --dryshowsVERCEL_ENVin env hashpnpm type-check:allrun uses Turbo cache (.tsbuildinforestored)Summary by CodeRabbit