hid-tmff2: add combined pedals and centered clutch support for T300RS#203
Open
Eispala wants to merge 1 commit into
Open
hid-tmff2: add combined pedals and centered clutch support for T300RS#203Eispala wants to merge 1 commit into
Eispala wants to merge 1 commit into
Conversation
- Add combine_pedals module param to merge gas/brake into a single Z axis - Add center_clutch module param to fix clutch at center (512) when combine_pedals is active (Needed for some games like NFS: MW 2005) - Expose both as sysfs attributes for runtime control - Add t300rs_raw_event to rewrite pedal data on the fly - Add t300rs_rdesc_nrm_combined HID descriptor for combined pedal mode
Owner
|
Hi, sorry for the delay, been kinda busy lately. Thanks for taking the time to share this, appreciate it. So the approach here is to modify the packets that the wheel sends out and let the HID layer take care of the rest. I guess I'm not entirely opposed to the idea, but I dislike how this implementation is very wheel-specific and uses magic constants to reach into the bag of bits that is each event. I also don't quite understand why the I'm admittedly not super well versed in the input layer of the Linux kernel, so I'm not entirely sure if there are better approaches to take, just trying to learn by asking questions :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
since Need For Speed: Most Wanted 2005 needs combined pedals to work, i set out to implement this feature.
I am a software developer by trade, but not in C and i have no clue about driver development.
So, disclaimer: I used AI to implement this. - After i got it to work, i cleaned the code up (as good as i could at least)
It's only implemented for the t300rs, as i have that wheel.
Changes:
I tested it in NFS: MW 2005 and it works (Combining Pedals at least, it still has some other issues).
Also i did some form of regression testing if you can call it that - other games still work.