New Features - #7
Open
ZeroCreeper wants to merge 2 commits into
Open
Conversation
Stream playback now supports Duration / Position tracking OnClipEnd event (fired when a clip is removed) ReadyForDestroy mechanism for gracefully stopping looping clips Refactoring loop + destroyOnEnd merged into a PlaybackMode enum (PlayOnce / Loop / NeverStop) Loop control moved from Pool coroutine into AudioClipPlayback internally; Pool no longer manages playback logic AddLiveStream parameter name → clipName (aligned with AddClip) Pool coroutine changed to yield return null for faster response Bug Fixes Ffmpeg.cs: extracted directory was deleted instead of the temp folder, causing exe loss GetDuration() was blocking thread pool synchronously RemoveAllClips() was missing Dispose() on clips Pool coroutine could hang indefinitely with certain Loop configurations Breaking Changes AddClip / AddLiveStream parameters changed from (loop, destroyOnEnd) → (playbackMode)
… paused stream path to prevent repeating the last frame's audio data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlaybackModeenum — mergedloop+destroyOnEndintoPlayOnce/Loop/NeverStopAudioClipPlayback; Pool no longer touches playback logicAddLiveStreamparameter aligned —name→clipName(consistent withAddClip)Duration/Positionproperties viaffprobeOnClipEndevent — fires when a clip is removed fromClipsByIdReadyForDestroymechanism — gracefully stopsLoopclips without the Pool directly modifying themyield return nullinstead ofWaitForSeconds(0.1f)RemoveAllClipsfixed — added.ToArray()to avoid collection modification during enumerationFfmpeg.csfixed — temp directory used for extraction; exe search path correctedGetDuration()fixed — changed from sync blocking toasync Task+ReadToEndAsync()