Clean up project solution structure#1538
Open
SaschaWillems wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Clean up project solution structure#1538SaschaWillems wants to merge 1 commit intoKhronosGroup:mainfrom
SaschaWillems wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Contributor
|
Looks much better! But I would not expect the And while you're at it: maybe you could move all those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With some recent additions, the Visual Studio solution generated via CMake became cluttered, confusing people as to what's the right project to actually launch:
This PR cleans up that project structure by moving the recently added vgf components to the ThirdParty folder and framework related projects to the framework folder. That only leaves the samples project at the top level, making it clear that this is the project people are supposed to start from the IDE:
Note that this is a pure visual change and doesn't change anything about the source code structure itself and does not affect the build in any way. It simple tells CMake that, if the IDE supports it, those projects should be displayed in their respective sub folders.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properly