added de bruijn blueprints#51
Conversation
|
There are no assert statements in test files, might need to add that @Monjistha99 |
| # Fabric edges (with redundancy) | ||
|
|
||
| for node in nodes: | ||
|
|
There was a problem hiding this comment.
please do code cleanup and remove extra spaces or new lines
There was a problem hiding this comment.
cleaned up code
| ) | ||
|
|
||
| hosts_per_switch = host_ports // hn | ||
| self.degree = degree |
There was a problem hiding this comment.
same - I dont think this is required?
| ) | ||
|
|
||
| # Access switch device | ||
| access_switch = Switch(port_count=sp) |
There was a problem hiding this comment.
you are creating a switch again - we dont need this - we need to use the same switch which is passed to the function - so think about it in a different manner
There was a problem hiding this comment.
instead of creating a switch again, I used the same switch for fabric and access switches
Monjistha99
left a comment
Monjistha99
left a comment
There was a problem hiding this comment.
added my comments wherever there was a review comment
Monjistha99
left a comment
Monjistha99
left a comment
There was a problem hiding this comment.
replied on reviews
3 participants
This MR contains 4 files on De bruijn fabric blueprint-