Fix token auth error causing jobs to fail, unit tests#41
Open
joevanwanzeeleKF wants to merge 7 commits into
Open
Fix token auth error causing jobs to fail, unit tests#41joevanwanzeeleKF wants to merge 7 commits into
joevanwanzeeleKF wants to merge 7 commits into
Conversation
* separating the writing on passphrase and cert; including parameters for passphrase path and cert and passphrase prop names * added additional logic to build request based on how the secret is stored. * updated remaining cert stores * Update generated docs * Updated password write to preserve existing secret content if any. * Update generated docs * documentation and manifest updates * Update generated docs * Trimming leading slashes from passphrase secret name * Update generated docs * added additional logging and null checking on response data. * Update generated docs * added null check in catch block for reading the cert and passphrase; removed newtonsoft.json from the solution. Added additional logging. * implemented check for KV version, format requests depending on result * Update generated docs * updated read/write operations on kv-v1 to reflect that the secrets are _always_ stored as JSON in v1. --------- Co-authored-by: Joe VanWanzeele <76071503+joevanwanzeeleKF@users.noreply.github.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
…on of KV V2 and logged warning. Added unit tests. License headers. Changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now catching unauthorized exception and continuing job (with assumption of KV V2 and logged warning.
Added unit tests. License headers. Changelog.