feat(ui): theme-aware colors for Banner and ToolExecution#3
Open
jakeschepis wants to merge 1 commit into
Open
Conversation
…olExecution All remaining hardcoded hex color values in Banner.tsx and ToolExecution.tsx now reference theme tokens (theme.primary, theme.textMuted, theme.warning, etc.) so the UI properly adapts between dark and light mode. Banner: added light-specific gradient palette, provider status uses theme.success. ToolExecution: diff lines, grep results, find/ls output, task lines, and MCP results all pull from theme tokens instead of baked-in dark-mode colors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all remaining hardcoded hex colors in
Banner.tsxandToolExecution.tsxwith theme tokens so the UI properly adapts between dark and light mode.Changes
Banner.tsx
theme.nameat render timetheme.successinstead of hardcoded#4ade80ToolExecution.tsx
theme.primary,theme.textMuted,theme.warning,theme.error,theme.success,theme.text,theme.textDim,theme.diffAdded,theme.diffRemoved) instead of baked-in dark-mode hex valuestheme.errorinstead of#f87171theme.warning/theme.textMutedinstead of#fbbf24/#9ca3afWhy
The theme system already supports dark/light mode switching via settings, but these two components still had ~20 hardcoded dark-mode colors. On light mode they looked washed out or invisible. Now everything adapts automatically.
No logic changes — just wiring existing theme tokens into the remaining components.
Test Plan
pnpm check && pnpm lint && pnpm format:check— all pass/settings— verify Banner gradient, tool output, diffs, grep results, and task lines are all readable🤖 Generated with Claude Code