Fix: Naming Changes#36
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Better align some method names.
Note
Medium Risk
Breaking renames across all public SDK surfaces (WASM/JS, WASI flat ABI, WIT, Java); integrators must update call sites, though on-chain identifiers are unchanged.
Overview
Renames account identity APIs across bindings, WASM, WASI (P1/P2/WIT), and Java so they match the reference SDK:
address/fromAddress/account_from_addressbecomepublicKeyString,fromPublicKeyString, andaccount_from_public_key_string(thekeeta_…string). Error codes shift fromINVALID_ADDRESStoINVALID_PUBLIC_KEY_STRING.Adds
fromPublicKeyAndType/publicKeyAndTypeStringfor the0x-prefixed[key_type_byte || raw_public_key]layout, with round-trip tests in Rust, P1/P2 host tests, WASM Playwright, and Java parity harnesses.Account.fromSeednow accepts an optional algorithm (defaultecdsa_secp256k1) in WIT, P2, and P1 (empty algo string); Java gains a two-argaccount(seed, index)overload.keetanetwork-clientOpenAPI responses are refactored into named component schemas; Java vote client usesCreateVoteResponseinstead ofCreateVote200Response. Crate versions are bumped (notablykeetanetwork-client-wasi0.5.0).Reviewed by Cursor Bugbot for commit c7c33dc. Bugbot is set up for automated code reviews on this repo. Configure here.