Chore: Centralize P1 Opaque-Handle Tables#31
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR centralizes opaque-handle storage for the WASI Preview 1 (P1) core module by replacing per-type HashMap handle tables with a reusable, generic HandleRegistry<T> shared in keetanetwork-bindings.
Changes:
- Introduced
keetanetwork_bindings::registry::HandleRegistry<T>to manage non-zero handle allocation, lookup, and release with consistentINVALID_HANDLEerrors. - Refactored
keetanetwork-client-wasiP1 state to useHandleRegistryinstances instead of manualnext+HashMaptables. - Exported the new
registrymodule fromkeetanetwork-bindings.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| keetanetwork-client-wasi/src/p1/mod.rs | Migrates P1 handle tables to HandleRegistry<T> and routes lookups/removals through the new API. |
| keetanetwork-bindings/src/registry.rs | Adds the generic handle registry implementation plus unit tests. |
| keetanetwork-bindings/src/lib.rs | Exposes the new registry module publicly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces manual HashMap handle tables in the P1 core module with a generic
HandleRegistry<T>.