chaining: validate requests and paths before network calls#372
Open
lucasrosa90 wants to merge 6 commits into
Open
chaining: validate requests and paths before network calls#372lucasrosa90 wants to merge 6 commits into
lucasrosa90 wants to merge 6 commits into
Conversation
lucasrosa90
requested review from
ezraripps and
sephynox
and removed request for
ezraripps
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…etwork/anchor into feature/chaining-validate-prepass
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoists the request and path-shape validations in
AnchorChainingPlan.#computePlaninto two pure helpers (validateRequest,validatePathStructure) that run before any network call, so structurally/request-invalid plans fail fast instead of after wasted provider round-trips (e.g. anaffinity:'to'+ asset-movement path no longer issues a persistent-forwarding lookup before being rejected).Changes
validateRequestderives amount/affinity and rejects bad value combinations.validatePathStructureenforces the static path rules (affinity/asset-movement, PFR must-be-last/recipient, keetaSend constraints) up front.Compatibility: non-breaking. Validators run inside
#computePlan, so per-path failure surfacing (getPlansPromise.allSettled/includeAllOutput) and directAnchorChainingPlan.create(...).rejectsbehavior are unchanged; all error messages are preserved verbatim.