fix(video-grabber): a bare apostrophe is not an invented word - #341
Merged
Conversation
Found while verifying 1,500 production summaries against their own source
transcripts: exactly one was reported as containing a word absent from its
source, and the "word" was a lone apostrophe.
_WORD was "[a-z0-9']+", which matches a standalone "'" as a token. _variants
strips it to the empty string, so it can never match anything in the source and
is always reported as invented. Requiring a token to START with an alphanumeric
keeps contractions and possessives ("don't", "city's") while dropping the bare
punctuation.
Harmless in tier 1, where the line is rebuilt from source indices and the
validator is only an assertion. It matters in tier 2, where every false
rejection discards a real summary and falls back.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
robbiebyrd
marked this pull request as ready for review
August 1, 2026 03:03
robbiebyrd
enabled auto-merge (squash)
August 1, 2026 03:03
Contributor
|
Contributor
|
✅ Playwright E2E — 9 passed · 0 failed · 0 flaky · 0 skipped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while verifying 1,500 production summaries against their own source transcripts: exactly one was reported as containing a word absent from its source, and the "word" was a lone apostrophe.
_WORD was "[a-z0-9']+", which matches a standalone "'" as a token. _variants strips it to the empty string, so it can never match anything in the source and is always reported as invented. Requiring a token to START with an alphanumeric keeps contractions and possessives ("don't", "city's") while dropping the bare punctuation.
Harmless in tier 1, where the line is rebuilt from source indices and the validator is only an assertion. It matters in tier 2, where every false rejection discards a real summary and falls back.