fix: 과거 날짜 목표 인증 시 GOAL_COMPLETED 알림 딥링크가 오늘로 가던 버그 수정#103
Merged
Conversation
GOAL_COMPLETED 알림 딥링크의 date가 인증 날짜가 아닌 LocalDate.now()로 설정되어, 과거 날짜로 인증해도 알림을 누르면 오늘 날짜 화면으로 이동하던 문제 해결. 근본 원인: PhotologCreatedEvent가 verificationDate를 담지 않아 리스너가 LocalDate.now()로 대체하고 있었음. (POKE/REACTION은 이미 verificationDate 사용) - PhotologCreatedEvent에 verificationDate 추가 - PhotoLogService.createPhotolog에서 verificationDate 전달 - handlePhotologCreated 딥링크 date를 event.verificationDate로 변경 - 미사용 LocalDate import 제거, 테스트를 과거 날짜로 검증하도록 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
과거 날짜로 목표를 인증하면, 파트너가 받는 "목표 완료(GOAL_COMPLETED)" 알림을 눌렀을 때 인증한 과거 날짜가 아니라 오늘 날짜 화면으로 이동.
원인
GOAL_COMPLETED 알림 딥링크의
date파라미터가 인증 날짜가 아닌LocalDate.now()로 설정됨 (NotificationEventListener.handlePhotologCreated).근본 원인:
PhotologCreatedEvent가verificationDate를 담고 있지 않아 리스너가LocalDate.now()로 대체하고 있었음.※ POKE / REACTION 딥링크는 이미
event.verificationDate사용 중.변경 내용
PhotologCreatedEvent에verificationDate필드 추가PhotoLogService.createPhotolog()에서 verificationDate 전달handlePhotologCreated딥링크date를event.verificationDate로 변경LocalDateimport 제거검증
:love:application:test통과