[TWI-124] fix: 양쪽 목표 완료 시 발행되던 DAILY_GOAL_ACHIEVED 알림 폐기#102
Merged
Conversation
두 번째로 인증샷을 올린 사람의 파트너가 GOAL_COMPLETED와 DAILY_GOAL_ACHIEVED를 거의 동시에 받는 푸시 폭탄 문제 해결. "양쪽 다 완료" 케이스의 알림을 FCM·알림센터 모두에서 미발행 처리. - PhotoLogService: checkAndPublishDailyGoalAchieved 호출/메서드 제거 - NotificationEventListener: handleDailyGoalAchieved 핸들러 제거 - NotificationEvents: DailyGoalAchievedEvent 제거 - 관련 테스트 및 NotificationTestApiSpec 예제 정리 - NotificationType.DAILY_GOAL_ACHIEVED enum은 기존 알림 데이터 호환성을 위해 유지(@Enumerated(EnumType.STRING)) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Test Results 22 files ±0 22 suites ±0 5s ⏱️ -1s Results for commit 7b99b52. ± Comparison against base commit c94cd1a. This pull request removes 1 test. |
ParkIsComing
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경 / 문제
포토로그 업로드 시 알림이 두 갈래로 발행됨:
PhotologCreatedEvent→ 파트너에게 GOAL_COMPLETEDDailyGoalAchievedEvent→ 양쪽 모두에게 DAILY_GOAL_ACHIEVED→ 두 번째로 인증샷을 올린 사람의 파트너가 GOAL_COMPLETED + DAILY_GOAL_ACHIEVED를 거의 동시에 수신(푸시 폭탄). 발행이 목표(goal)별이라 공유 목표가 많으면 더 심함.
변경 내용
"양쪽 다 완료" 케이스의 알림을 FCM·알림센터(DB) 모두에서 미발행 처리.
PhotoLogService:checkAndPublishDailyGoalAchieved호출/메서드/import 제거NotificationEventListener:handleDailyGoalAchieved핸들러 제거NotificationEvents:DailyGoalAchievedEvent제거NotificationEventListenerTest) 및NotificationTestApiSpec예제 정리Notification엔티티가@Enumerated(EnumType.STRING)이라 기존 알림 row에"DAILY_GOAL_ACHIEVED"문자열이 저장돼 있음.→ enum 상수
NotificationType.DAILY_GOAL_ACHIEVED는 유지(삭제 시 기존 알림센터 조회 깨짐).검증
:love:application:test통과🤖 Generated with Claude Code